fix: ci failure tests - WPB-23003

.github/workflows/_reusable_run_tests.yml

@@ -224,7 +224,7 @@ jobs:
           {
             echo "## 📊 Allure Report Generated Successfully";
             echo "";
-            echo "**Artifact Name:** \`html-report-${{ github.run_number }}\`";
+            echo "**Artifact Name:** \`html-report-${{ github.run_number }}-${{ env.SANITIZED_BRANCH }}\`";
             echo "";
             echo "### 📥 How to View the Report";
             echo "";

WireUI/Sources/WireLocators/Locators.swift

@@ -66,6 +66,7 @@ public enum Locators {
         case blockButtonOnBottomSheet
         case bottomBarArchivedButton
         case accountProfileImageView
+        case loadBar
     }
 
     public enum SettingsPage: String {

wire-ios/Wire-iOS/Sources/UserInterface/Components/NetworkStatus/NetworkStatusView.swift

@@ -18,6 +18,7 @@
 
 import UIKit
 import WireDesign
+import WireLocators
 import WireLogging
 import WireSystem
 
@@ -106,8 +107,9 @@ final class NetworkStatusView: UIView {
 
     override init(frame: CGRect) {
         self.connectingView = BreathLoadingBar.withDefaultAnimationDuration()
-        connectingView.accessibilityIdentifier = "LoadBar"
+        connectingView.accessibilityIdentifier = Locators.ConversationsPage.loadBar.rawValue
         self.offlineView = OfflineBar()
+        offlineView.accessibilityIdentifier = "offlineLoadbar"
 
         super.init(frame: frame)
 

wire-ios/WireUITests/Pages/ActiveConversationPage .swift

@@ -46,7 +46,7 @@ class ActiveConversationPage: PageModel {
     }
 
     var messageLabels: XCUIElementQuery {
-        app.textViews.matching(identifier: Locators.ActiveConversationPage.message.rawValue)
+        app.descendants(matching: .any).matching(identifier: Locators.ActiveConversationPage.message.rawValue)
     }
 
     func getSenderName() -> String? {

wire-ios/WireUITests/Pages/ConversationsPage.swift

@@ -64,6 +64,10 @@ class ConversationsPage: PageModel {
         app.buttons[Locators.ConversationsPage.accountProfileImageView.rawValue]
     }
 
+    var loadBar: XCUIElement {
+        app.descendants(matching: .any)[Locators.ConversationsPage.loadBar.rawValue]
+    }
+
     func openSettings() throws -> SettingsPage {
         settingsButton.tap()
         return try SettingsPage()
@@ -75,7 +79,7 @@ class ConversationsPage: PageModel {
     }
 
     func openUserProfilePage() throws -> UserProfilePage {
-        try VerifyUserIsOnConversationsTab()
+        try letTheSyncfinish()
         accountProfileImageView.waitAndTap()
         return try UserProfilePage()
     }
@@ -86,6 +90,7 @@ class ConversationsPage: PageModel {
     }
 
     func openPendingRequest() throws -> ConnectionRequestsPage {
+        try letTheSyncfinish()
         XCTAssertTrue(conversationCell.waitForExistence(timeout: 5), "Conversation cell did not appear")
 
         let maxDuration: TimeInterval = 10
@@ -101,6 +106,7 @@ class ConversationsPage: PageModel {
     }
 
     func openConversation() throws -> ActiveConversationPage {
+        try letTheSyncfinish()
         XCTAssertTrue(conversationCell.waitForExistence(timeout: 5), "Conversation cell did not appear")
 
         let maxDuration: TimeInterval = 10
@@ -130,11 +136,7 @@ class ConversationsPage: PageModel {
         conversationCell.label
     }
 
-    // Problem: Opening the user profile can occasionally fail while sync is in progress after login
-    // Workaround: Assert the presence of some UI elements to give the sync time to complete.
-    func VerifyUserIsOnConversationsTab() throws {
-        XCTAssertTrue(plusButtonToCreateGroup.exists)
-        XCTAssertTrue(archivedButton.exists)
-        XCTAssert(settingsButton.exists)
+    func letTheSyncfinish() throws {
+        loadBar.waitToDisappear()
     }
 }

wire-ios/WireUITests/Pages/OptionsOnSettingsPage.swift

@@ -49,22 +49,19 @@ class OptionsOnSettingsPage: PageModel {
         return self
     }
 
-    func enterPasscode(_ pass: String) throws -> ConversationsPage {
+    func enterPasscode(_ passcode: String) throws -> ConversationsPage {
         let springboard = XCUIApplication(bundleIdentifier: "com.apple.springboard")
         let passcodeField = springboard.secureTextFields["Passcode field"].firstMatch
 
-        guard passcodeField.waitAndTap()
-        else {
-            XCTFail("Passcode SecureTextField did not appear")
-            throw XCTSkip("Passcode field not available")
-        }
-        try passcodeField.tapIfKeyboardNotFocused().typeText(pass)
-
-        let doneButton = springboard.keyboards.buttons["Done"].firstMatch
-        if doneButton.waitAndTap() {
-            // Tapped successfully
-        } else {
-            springboard.typeText(XCUIKeyboardKey.return.rawValue)
+        // Sometimes the splashscreen stays visible for unexpectedly long.
+        if passcodeField.waitAndTap(timeout: 8.0) {
+            try passcodeField.tapIfKeyboardNotFocused().typeText(passcode)
+            let doneButton = springboard.keyboards.buttons["Done"].firstMatch
+            if doneButton.waitAndTap() {
+                // Tapped successfully
+            } else {
+                springboard.typeText(XCUIKeyboardKey.return.rawValue)
+            }
         }
         return try ConversationsPage()
     }

wire-ios/WireUITests/Pages/PhotosAppPage.swift

@@ -59,7 +59,9 @@ class PhotosAppPage: PageModel {
     }
 
     func selectConversation(name: String) -> XCUIElement {
-        photosApp.staticTexts[name].firstMatch
+        var conversationCell = photosApp.staticTexts[name]
+        XCTAssertTrue(conversationCell.waitForExistence(timeout: timeout))
+        return conversationCell.firstMatch
     }
 
     @discardableResult