Skip to content

fix: tags not tappable - WPB-23240 🍒#4262

Merged
jullianm merged 1 commit intorelease/cycle-4.15from
fix/tags-not-tappable-cherry-pick
Feb 4, 2026
Merged

fix: tags not tappable - WPB-23240 🍒#4262
jullianm merged 1 commit intorelease/cycle-4.15from
fix/tags-not-tappable-cherry-pick

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 4, 2026

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-23240 [iOS] Unable to tap a tag on tags filters screen after pulling to refresh

Issue

This PR fixes an issue in the tags filter screen where after a pull to refresh, the already presented tags are no longer tappable. Issue is that when selecting a tag after a pull to refresh, the selected tag ID no longer finds a match in the "cached" tags model. Solution is to ensure the presented tags are correctly reset when pulling to refresh so tags IDs are correctly in sync.

Testing

go to Drive tab, open tags filter screen (top right corner), pull to refresh, try to select a tag, then it should select/deselect the tag properly.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm closed this Feb 4, 2026
@jullianm jullianm reopened this Feb 4, 2026
@jullianm jullianm enabled auto-merge (squash) February 4, 2026 08:32
Copy link
Collaborator

@zenkins zenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved cherry-pick PR 🍒.

@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 4, 2026

Test Results

2 122 tests   2 095 ✅  2m 35s ⏱️
  354 suites     27 💤
    2 files        0 ❌

Results for commit 7a2b0f2.

Summary: workflow run #21664244102
Allure report (download zip): html-report-27525-fix_tags-not-tappable-cherry-pick

@jullianm jullianm merged commit 5079f95 into release/cycle-4.15 Feb 4, 2026
12 checks passed
@jullianm jullianm deleted the fix/tags-not-tappable-cherry-pick branch February 4, 2026 08:48
zenkins pushed a commit that referenced this pull request Feb 4, 2026
Co-authored-by: Jullian Mercier <31648126+jullianm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants