fix: tags not tappable - WPB-23240 🍒 🍒#4264
Merged
Conversation
Co-authored-by: Jullian Mercier <31648126+jullianm@users.noreply.github.com>
jullianm
approved these changes
Feb 4, 2026
zenkins
approved these changes
Feb 4, 2026
Collaborator
zenkins
left a comment
zenkins
left a comment
There was a problem hiding this comment.
✅ Auto-approved cherry-pick PR 🍒.
Contributor
Author
Test Results255 tests 255 ✅ 28s ⏱️ Results for commit 0ddaebf. Summary: workflow run #21666112040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
This PR fixes an issue in the tags filter screen where after a pull to refresh, the already presented tags are no longer tappable. Issue is that when selecting a tag after a pull to refresh, the selected tag ID no longer finds a match in the "cached" tags model. Solution is to ensure the presented tags are correctly reset when pulling to refresh so tags IDs are correctly in sync.
Testing
go to Drive tab, open tags filter screen (top right corner), pull to refresh, try to select a tag, then it should select/deselect the tag properly.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: