Skip to content

fix: replace attachment menu with alert - WPB-21656 🍒#4273

Merged
jullianm merged 1 commit intodevelopfrom
fix/replacing-attachment-menu-cherry-pick
Feb 5, 2026
Merged

fix: replace attachment menu with alert - WPB-21656 🍒#4273
jullianm merged 1 commit intodevelopfrom
fix/replacing-attachment-menu-cherry-pick

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Feb 5, 2026

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-21656 [iOS] Sorting in all files

Issue

This PR replaces the attachment Menu that shows up when a file could not be uploaded as it was introducing a UI bug when the keyboard was showing. As discussed with design team, we prefer to display an alert instead to avoid that bug.

Simulator Screenshot - Snapshots - 2026-02-05 at 15 12 24

Testing

have an attachment uploaded that ends up in error, tap on the "elipsis" button in top right corner of the attachment. Before it was showing a context menu, now it displays an alert, same actions as before (remove file or retry).

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Collaborator

@zenkins zenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Auto-approved cherry-pick PR 🍒.

@jullianm jullianm enabled auto-merge February 5, 2026 14:36
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 5, 2026

Test Results

255 tests   255 ✅  32s ⏱️
 53 suites    0 💤
  1 files      0 ❌

Results for commit 81cb3c2.

Summary: workflow run #21715610133
Allure report (download zip): html-report-27575-fix_replacing-attachment-menu-cherry-pick

@jullianm jullianm added this pull request to the merge queue Feb 5, 2026
Merged via the queue into develop with commit 4b0ae05 Feb 5, 2026
10 checks passed
@jullianm jullianm deleted the fix/replacing-attachment-menu-cherry-pick branch February 5, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants