Skip to content

fix: replace attachment menu with alert - WPB-21656 🍒 #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jullianm merged 1 commit into from
Feb 5, 2026
+14 −4
Merged

fix: replace attachment menu with alert - WPB-21656 🍒 #4273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WireMessaging/Sources/WireMessagingUI/Resources/Localization/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
"conversation.channelHistory.fetchChannelHistoryDepthOptions.error" = "An error occurred while fetching channel history depth options.";
"conversation.channelHistory.updateHistoryDepth.error" = "An error occurred while updating channel history depth.";
"conversation.file.preview.open" = "Open preview";
"conversation.draft.attachmentMenu.errorTitle" = "Unable to load file";
"conversation.draft.attachmentMenu.retry" = "Retry";
"conversation.draft.attachmentMenu.remove" = "Remove File";

Expand Down
17 changes: 13 additions & 4 deletions ...ources/WireMessagingUI/WireDrive/Components/AttachmentsCarousel/AttachmentsCarousel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ private struct AttachmentsCarouselItemView: View {
static let buttonCornerRadius: CGFloat = 24
}

@State private var showErrorAlert = false

let item: AttachmentsCarouselItem
let onTap: () -> Void
let onRemove: () -> Void
Expand All @@ -83,7 +85,15 @@ private struct AttachmentsCarouselItemView: View {
.padding(.trailing, Constants.trailingPadding)

cornerButton
}
}.alert(
L10n.Localizable.Conversation.Draft.AttachmentMenu.errorTitle,
isPresented: $showErrorAlert,
actions: {
Button(L10n.Localizable.Conversation.Draft.AttachmentMenu.remove, action: { onRemove() })
Button(L10n.Localizable.Conversation.Draft.AttachmentMenu.retry, action: { onRetry() })

}
)
}

@ViewBuilder var content: some View {
Expand Down Expand Up @@ -119,9 +129,8 @@ private struct AttachmentsCarouselItemView: View {
Spacer()

if item.state.isFailed {
Menu {
Button(L10n.Localizable.Conversation.Draft.AttachmentMenu.retry, action: onRetry)
Button(L10n.Localizable.Conversation.Draft.AttachmentMenu.remove, action: onRemove)
Button {
showErrorAlert = true
} label: {
Image(systemName: "ellipsis.circle.fill")
.resizable()
Expand Down
Loading