Skip to content

Conversation

@gosha212
Copy link
Contributor

@gosha212 gosha212 commented Jan 29, 2025

As preparation for new arch, the project was upgraded to support RN 76 without the new arch.
New arch is still in progress
#7941

@retyui
Copy link
Contributor

retyui commented Feb 2, 2025

I'm so happy, FINALLY!

@d4vidi
Copy link
Collaborator

d4vidi commented Feb 2, 2025

I'm so happy, FINALLY!

Lol thanks, I'll review this personally within days

Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well looks great but it definitely looks like this change is not backwards compatible. Let's consider the limitations together.

Copy link
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check (and fix?) for RN73

@Moises-dev08
Copy link

Moises-dev08 commented Feb 5, 2025

We are stuck with building our current new project due to this issue. 🙏 Hope it can be merged soon 🙏
thank you for you hard work guys!! 👏 @gosha212 👏

@Yash2711
Copy link

Yash2711 commented Feb 6, 2025

Same here, we are also stuck upgrading our project to 0.76.X. Hope this gets merged soon.

@gosha212
Copy link
Contributor Author

gosha212 commented Feb 6, 2025

@Yash2711 @Moises-dev08 I'm releasing an RC version for you. It is basically ready. We are still testing backward compatibility to RN 73.
Here is the build: https://buildkite.com/wix-mobile-oss/react-native-navigation/builds/1513#0194da4c-3f1a-4935-9be7-fb7d3ae1493f

This is the version: 7.41.0-rc01

d4vidi
d4vidi previously approved these changes Feb 6, 2025
@gosha212 gosha212 merged commit 375636d into master Feb 6, 2025
3 of 4 checks passed
@gosha212 gosha212 deleted the feat/rn76-oldarch branch February 6, 2025 14:11
@Moises-dev08
Copy link

@gosha212 it seems that the release failed
Screenshot 2025-02-06 at 16 22 56

@gosha212
Copy link
Contributor Author

gosha212 commented Feb 6, 2025

@Moises-dev08 you can take 7.42.0

@Moises-dev08
Copy link

Moises-dev08 commented Feb 6, 2025

@gosha212 I'm not able to do it. The latest is v7.0.14..

Screenshot 2025-02-06 at 18 21 16 Screenshot 2025-02-06 at 18 21 52

@retyui
Copy link
Contributor

retyui commented Feb 6, 2025

@Moises-dev08 you used incorrect package

@react-navigation/native - completely different library

@retyui
Copy link
Contributor

retyui commented Feb 6, 2025

https://www.npmjs.com/package/react-native-navigation?activeTab=versions

Screenshot_20250206-223245

@Moises-dev08
Copy link

Ups my bad. Thank you my friend!

@tarouboy
Copy link

Trying out version 8.0.0
with RN 0.76.7

App able to build, however when app launches return this error:
Native module RNNBridgeModule tried to override NavigationModule. Check the getPackages() method in MainApplication.java, it might be that module is being created twice. If this was your intention, set canOverrideExistingModule=true. This error may also be present if the package is present only once in getPackages() but is also automatically added later during build time by autolinking. Try removing the existing entry and rebuild.

This is the code inside playground/MainApplication.java

@Override
public List<ReactPackage> getPackages() {
    ArrayList<ReactPackage> packages = new PackageList(this).getPackages();
    packages.add(new NavigationPackage(mReactNativeHost));
    return packages;
}

After changing it to:

@Override
public List<ReactPackage> getPackages() {
    return new PackageList(this).getPackages();
}

The error resolved and the app able to run.

d4vidi added a commit that referenced this pull request Apr 17, 2025
d4vidi added a commit that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants