-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feat/rn76 oldarch #7967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/rn76 oldarch #7967
Conversation
Fixed ios pod file
|
I'm so happy, FINALLY! |
Lol thanks, I'll review this personally within days |
d4vidi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well looks great but it definitely looks like this change is not backwards compatible. Let's consider the limitations together.
lib/android/app/src/main/java/com/reactnativenavigation/utils/ReactTypefaceUtils.java
Show resolved
Hide resolved
...main/java/com/reactnativenavigation/viewcontrollers/viewcontroller/LayoutDirectionApplier.kt
Show resolved
Hide resolved
...java/com/reactnativenavigation/viewcontrollers/bottomtabs/attacher/modes/AttachModeTest.java
Show resolved
Hide resolved
d4vidi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check (and fix?) for RN73
|
We are stuck with building our current new project due to this issue. 🙏 Hope it can be merged soon 🙏 |
|
Same here, we are also stuck upgrading our project to 0.76.X. Hope this gets merged soon. |
|
@Yash2711 @Moises-dev08 I'm releasing an RC version for you. It is basically ready. We are still testing backward compatibility to RN 73. This is the version: |
|
@gosha212 it seems that the release failed |
|
@Moises-dev08 you can take 7.42.0 |
|
@gosha212 I'm not able to do it. The latest is v7.0.14..
|
|
@Moises-dev08 you used incorrect package @react-navigation/native - completely different library |
|
Ups my bad. Thank you my friend! |
|
Trying out version 8.0.0 App able to build, however when app launches return this error: This is the code inside playground/MainApplication.java After changing it to: The error resolved and the app able to run. |




As preparation for new arch, the project was upgraded to support RN 76 without the new arch.
New arch is still in progress
#7941