-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Feat/rn76 oldarch #7967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/rn76 oldarch #7967
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
2a776db
Upgraded android to work with rn 77
gosha212 100dd5b
Upgraded to the latest version of detox
gosha212 c742e3b
Added react types.
gosha212 aee806a
Updated pod filke
gosha212 cacd4fe
Fixed es lint error
gosha212 419eed1
Upgraded reanimated
gosha212 6f2ca4c
Fixed ios build
gosha212 fd97ab2
Fixed ios build
gosha212 5dcf7c6
Fixed one test in android
gosha212 cc25411
Fixed android tests
gosha212 e036898
Fixed android unit tests
gosha212 24144b1
Fixed android unit tests
gosha212 68cce81
Fixed android tests
gosha212 534dbb7
Fixed mocked tests
gosha212 e719a90
Downgrade to RN 76
gosha212 ff9ed27
support ios
gosha212 7183b68
fixed android screenshot
gosha212 550a73f
fixed android screenshot
gosha212 81f1eb6
Reimplemented missing bar style in iOS
gosha212 2000684
Reimplemented missing bar style in iOS
gosha212 6b32776
Fixed ios bar styling
gosha212 560f994
Removed unused library
gosha212 1ed449b
Upgraded roboletric to run on updated sdk
gosha212 a199c01
Revert "Upgraded roboletric to run on updated sdk"
gosha212 7beb52c
Fixes for PR
gosha212 b815cab
Merge branch 'master' into feat/rn76-oldarch
gosha212 960085e
Fixed ios build
gosha212 465b63c
Test commit
gosha212 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,6 @@ module.exports = { | |
| plugins: ['@typescript-eslint'], | ||
| env: { | ||
| jest: true, | ||
| 'jest/globals': true, | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -244,3 +244,4 @@ Mock.js | |
| Mock.d.ts | ||
|
|
||
| Gemfile.lock | ||
| /playground/ios/.xcode.env.local | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 4 additions & 2 deletions
6
lib/android/app/src/main/java/com/reactnativenavigation/utils/ReactViewGroup.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| package com.reactnativenavigation.utils | ||
|
|
||
| import com.facebook.react.views.view.ReactViewBackgroundDrawable | ||
| import com.facebook.react.common.annotations.UnstableReactNativeAPI | ||
| import com.facebook.react.uimanager.drawable.CSSBackgroundDrawable | ||
| import com.facebook.react.views.view.ReactViewGroup | ||
|
|
||
| @OptIn(UnstableReactNativeAPI::class) | ||
| val ReactViewGroup.borderRadius: Float | ||
| get() = (background as? ReactViewBackgroundDrawable)?.fullBorderRadius ?: 0f | ||
| get() = (background as? CSSBackgroundDrawable)?.fullBorderWidth ?: 0f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 8 additions & 4 deletions
12
...n/java/com/reactnativenavigation/viewcontrollers/viewcontroller/LayoutDirectionApplier.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,19 @@ | ||
| package com.reactnativenavigation.viewcontrollers.viewcontroller | ||
|
|
||
| import android.annotation.SuppressLint | ||
| import com.facebook.react.ReactInstanceManager | ||
| import com.facebook.react.modules.i18nmanager.I18nUtil | ||
| import com.reactnativenavigation.options.Options | ||
|
|
||
| class LayoutDirectionApplier { | ||
| fun apply(root: ViewController<*>, options: Options, instanceManager: ReactInstanceManager) { | ||
| if (options.layout.direction.hasValue() && instanceManager.currentReactContext != null) { | ||
| @SuppressLint("WrongConstant") | ||
| fun apply(root: ViewController<*>, options: Options) { | ||
| val currentContext = root.view?.context ?: return | ||
gosha212 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if (options.layout.direction.hasValue()) { | ||
| root.activity.window.decorView.layoutDirection = options.layout.direction.get() | ||
| I18nUtil.getInstance().allowRTL(instanceManager.currentReactContext, options.layout.direction.isRtl) | ||
| I18nUtil.getInstance().forceRTL(instanceManager.currentReactContext, options.layout.direction.isRtl) | ||
| I18nUtil.instance.allowRTL(currentContext, options.layout.direction.isRtl) | ||
| I18nUtil.instance.forceRTL(currentContext, options.layout.direction.isRtl) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.