Skip to content

Revert intro-fix for bottom-tabs support for edge2edge #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d4vidi wants to merge 4 commits into from
Closed

Revert intro-fix for bottom-tabs support for edge2edge #8085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62d7923
Revert "fix(sdk35): Apply inset over bottom-tabs (#7991)"
d4vidi Aug 13, 2025
a3373b7
Update package.json version to 7.51.0-rc.0 [buildkite skip]
mobileoss Aug 13, 2025
5b22455
Skip failing gren
d4vidi Aug 13, 2025
c8b52b5
Update package.json version to 7.51.0-rc.1 [buildkite skip]
mobileoss Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions .../main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,11 @@
import android.animation.Animator;
import android.app.Activity;
import android.content.res.Configuration;
import android.view.View;
import android.view.ViewGroup;

import androidx.annotation.NonNull;
import androidx.annotation.RestrictTo;
import androidx.coordinatorlayout.widget.CoordinatorLayout;
import androidx.core.graphics.Insets;
import androidx.core.view.WindowInsetsCompat;

import com.aurelhubert.ahbottomnavigation.AHBottomNavigation;
import com.aurelhubert.ahbottomnavigation.AHBottomNavigationItem;
Expand Down Expand Up @@ -108,7 +105,6 @@ public BottomTabsLayout createView() {
bottomTabs.addItems(createTabs());
setInitialTab(resolveCurrentOptions);
tabsAttacher.attach();

return root;
}

Expand Down Expand Up @@ -313,14 +309,6 @@ public Animator getPopAnimation(Options appearingOptions, Options disappearingOp
return presenter.getPopAnimation(appearingOptions, disappearingOptions);
}

@Override
protected WindowInsetsCompat onApplyWindowInsets(View view, WindowInsetsCompat insets) {
Insets sysInsets = insets.getInsets(WindowInsetsCompat.Type.systemBars());
view.setPaddingRelative(0, 0, 0, sysInsets.bottom);
return WindowInsetsCompat.CONSUMED;
}


@RestrictTo(RestrictTo.Scope.TESTS)
public BottomTabs getBottomTabs() {
return bottomTabs;
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-navigation",
"version": "7.50.0",
"version": "7.51.0-rc.1",
"description": "React Native Navigation - truly native navigation for iOS and Android",
"license": "MIT",
"nativePackage": true,
Expand Down
12 changes: 8 additions & 4 deletions scripts/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,14 @@ function updatePackageJsonGit(version) {
}

function draftGitRelease(version) {
exec.execSync(`npx gren release --tags=${version}`);
exec.execSync(`sleep 30`);
// For some unknown reason, gren release works well only when calling it twice.
exec.execSync(`npx gren release --tags=${version}`);
try {
exec.execSync(`npx gren release --tags="${version}"`);
exec.execSync(`sleep 30`);
// For some unknown reason, gren release works well only when calling it twice.
exec.execSync(`npx gren release --tags="${version}"`);
} catch (err) {
console.warn('Failed to create a GitHub release draft ==> skipping', err);
}
}

run();