wc_XChaCha20Poly1305_Init: NULL check aead, not ad #9692
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Root cause is a lack of unit tests for XChaCha20Poly1305. @rlm2002 has accepted the task of writing unit tests in a separate PR. |
Member
Author
|
jenkins retest this please |
Member
Author
|
Jenkins retest this please. |
Member
Author
|
jenkins retest this please. |
Member
Author
|
PR Capt, please merge. |
dgarske
requested changes
Jan 21, 2026
dgarske
approved these changes
Jan 21, 2026
Member
Author
|
Jenkins retest this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9690