Skip to content

wc_XChaCha20Poly1305_Init: NULL check aead, not ad #9692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgarske merged 2 commits into from
Jan 22, 2026
Merged

wc_XChaCha20Poly1305_Init: NULL check aead, not ad #9692

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4550814
wc_XChaCha20Poly1305_Init: NULL check aead, not ad
anhu Jan 20, 2026
7d7299e
Do not allow NULL with non-zero length.
anhu Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wolfcrypt/src/chacha20_poly1305.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ int wc_XChaCha20Poly1305_Init(
byte authKey[CHACHA20_POLY1305_AEAD_KEYSIZE];
int ret;

if ((ad == NULL) || (nonce == NULL) || (key == NULL))
if ((aead == NULL) || (nonce == NULL) || (key == NULL))
return BAD_FUNC_ARG;

if ((key_len != CHACHA20_POLY1305_AEAD_KEYSIZE) ||
Expand Down