[WOOMOB-1980] Add Learn more CTA to Mobile Announcements #16591
+267
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staskus
added
type: enhancement
Collaborator
|
|
staskus
changed the title
staskus
changed the title
Add ability to fetch test announcements targeting version 999.0 and reset announcement state from the Debug Panel. This allows testing the What's New modal without affecting production users. - Add synchronizeAnnouncementsForDebug action to fetch with custom app version - Add deleteSavedAnnouncement action to reset announcement state - Add Identifiable conformance to Announcement for SwiftUI sheet presentation - Add Announcements section to DebugPanelView with fetch and reset buttons
Test the new synchronizeAnnouncementsForDebug and deleteSavedAnnouncement actions to ensure proper functionality of the debug panel features.
Add missing learnMoreURL parameter to ReportItem initializer in test.
The test uses MockInMemoryStorage but deleteSavedAnnouncement uses FileManager.default directly, causing the test to fail when the file doesn't exist on disk.
1 task
The API provides detailsUrl at the announcement level, not per feature. Simplified the implementation to: - Show "Learn more" + "Not now" if detailsUrl exists - Show "Continue" if no detailsUrl Removed per-feature learnMoreURL from ReportItem and IconListItem.
Rename keys to follow naming convention: - learnMore.link → reportList.learnMore.link - wpcomPushNotificationsBenefitsView.notNowButton → reportList.notNow.button
- Show generic "Failed to fetch announcement" error - Silently ignore reset errors (file may not exist)
No longer needed after removing per-feature learn more links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: pdfdoF-8Ff-p2
WOOMOB-1980
Mobile announcements tool supports passing a learn more URL (
detailsUrl). However, it is not used in the app. This PR adds optional "Learn more" link support for What's New feature announcements.Announcement Display States
detailsUrlprovideddetailsUrlprovidedFor easier testing:
Testing
A. Live Test via Debug Panel
Ensure test announcement is enabled:
APP VERSION = 999.0and forWoo iOSis enabled (Wait a minute or two after enabling, disable after testing)Fetch and display the announcement:
Re-test as needed:
B. Preview All States
View SwiftUI previews to see announcement display variations:
ReportListpreviews show both states (with and without learn more URL)Video
Test announcement
Test.Announcement.mov
RELEASE-NOTES.txtif necessary.