[POS FTS] 2: Add search index builder with rebuild and search #16595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces POSSearchIndexBuilder with full-text search capabilities: - rebuildIndex: clears and re-indexes all eligible products and variations - search/searchCount: FTS5 queries with prefix matching and BM25 ranking - needsRebuild: detects when index is stale - buildFTSQuery: handles multi-word prefix search with special char escaping Adds posEligibleProductsRequest and posAllVariationsRequest to model types for index population queries. Includes comprehensive test suite. Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 task
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
joshheald
commented
Jan 30, 2026
|
|
||
| /// Returns a request for all non-downloadable variations for a site | ||
| static func posAllVariationsRequest(siteID: Int64) -> QueryInterfaceRequest<PersistedProductVariation> { | ||
| return PersistedProductVariation |
Contributor
Author
There was a problem hiding this comment.
Shouldn't this use a baseQuery?
| ) | ||
|
|
||
| try db.execute( | ||
| sql: "INSERT INTO pos_search_fts (searchable_text, siteID, itemType, itemID, parentProductID) VALUES (?, ?, ?, ?, ?)", |
Contributor
Author
There was a problem hiding this comment.
Double check injection risk
| // MARK: - Private | ||
|
|
||
| private static func buildFTSQuery(from term: String) -> String { | ||
| let words = term.components(separatedBy: CharacterSet.alphanumerics.inverted) |
Contributor
Author
There was a problem hiding this comment.
Check non-latin languages...
| let parentProduct = try PersistedProduct.fetchOne(db, key: ["siteID": siteID, "id": variation.productID]) | ||
|
|
||
| let attributes = try PersistedProductVariationAttribute | ||
| .filter(PersistedProductVariationAttribute.Columns.siteID == siteID) |
Contributor
Author
There was a problem hiding this comment.
perhaps a basequery?
Comment on lines
+290
to
+291
| @Test("search finds variations by attribute") | ||
| func test_search_finds_variations_by_attribute() async throws { |
Contributor
Author
There was a problem hiding this comment.
Is this a duplicate test?
- Add baseQuery to PersistedProductVariation for consistency with PersistedProduct pattern (reviewer comment on posAllVariationsRequest) - Fix buildFTSQuery to handle CJK ideographs correctly by splitting each character individually, matching FTS5 unicode61 tokenizer behavior (reviewer comment about non-latin language support) - Extract tokenize function and add comprehensive tests for tokenization covering CJK, Japanese kana/kanji, Korean, Arabic, Hebrew, emoji Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: WOOMOB-2109
Merge after #16594
Description
Introduces
POSSearchIndexBuilderwith:rebuildIndex: clears and re-indexes all eligible products and variations for a sitesearch/searchCount: FTS5 queries with prefix matching and BM25 rankingneedsRebuild: detects when the index is stale by comparing entry count to eligible itemsclearIndex: removes all FTS entries for a sitebuildFTSQuery: splits search terms on non-alphanumeric characters and wraps each word as a quoted prefix queryAlso adds
posEligibleProductsRequestonPersistedProductandposAllVariationsRequestonPersistedProductVariationfor index population queries.Includes comprehensive test suite (21 tests).
Test Steps
POSSearchIndexBuilderTests— all tests should passRELEASE-NOTES.txtif necessary.