Skip to content

Address localization and test build failures #23960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 2 commits into from
Jan 9, 2025
Merged

Address localization and test build failures #23960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34775f3
Flatten a nested localized string to avoid `genstrings` failure
mokagio Jan 8, 2025
b491858
Import `WordPressUI` in `SiteIconViewModelTests`
mokagio Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/Classes/Utility/WebViewController/WebKitViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class WebKitViewController: UIViewController, WebKitAuthenticatable {
style: .plain,
target: self,
action: #selector(share))
button.title = NSLocalizedString(SharedStrings.Button.share, comment: "Button label to share a web page")
button.title = NSLocalizedString("webKit.button.share", value: "Share", comment: "Button label to share a web page")
return button
}()
@objc lazy var safariButton: UIBarButtonItem = {
Expand Down
2 changes: 1 addition & 1 deletion WordPress/WordPressTest/SiteIconViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import UIKit
import XCTest

import WordPressUI
@testable import WordPress

final class SiteIconViewModelTests: XCTestCase {
Expand Down
Loading