Address localization and test build failures#23960
Merged
kean merged 2 commits intochristmas-feature-branchfrom Jan 9, 2025
Merged
Address localization and test build failures#23960kean merged 2 commits intochristmas-feature-branchfrom
kean merged 2 commits intochristmas-feature-branchfrom
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23960-b491858 | |
| Version | 25.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b491858 | |
| App Center Build | WPiOS - One-Offs #11303 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23960-b491858 | |
| Version | 25.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b491858 | |
| App Center Build | jetpack-installable-builds #10336 |
kean
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


In #23951 (comment) I commented regarding a few build failures unrelated to the CocoaPods removal I found when creating #23958
This PR addresses them, see commits list.
I also noticed that the UI tests seem to fail consistently, see for example:
The failing tests are:
I downloaded the test results from Buildkite and had a look. Here's what I found that might help further fixing.
I think
testBasicPostPublishWithCategoryAndTagandtestTextPostPublishmight be failing because the blogging reminders prompt is not dismissed after creating the post:As for
testAddRemoveFeaturedImage(), it might be failing because of a change in labels. See in the screenshot of the test result how the test is looking for"CurrentFeaturedImage"but that only matches for that string are in the test code itself.