Remove CocoaPods by mokagio · Pull Request #23951 · wordpress-mobile/WordPress-iOS

mokagio · 2025-01-07T06:51:37Z

Picks up where #23750, but starting from scratch because of too many project file changes since then, and completes the migration away from CocoaPods as the mean of linking the Gutenberg XCFramework.

The sequence of changes is roughly:

De-integrate CocoaPods
Drag-n-drop the xcframeworks
Tweak build settings to work around compilation errors due to the frameworks see fbb0997 and 4a29aea
Update the script that copies the React Native App.js file from the XCFramework to the build products as a jsbundle to use the new location
Remove the various "if cocoapods" kind of checks from app code and automation

Two things noteworthy:

I had to disable a couple of clang checks, CLANG_WARN_STRICT_PROTOTYPES and CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER, because of build failures in the XCFramework imports. It doesn't seem ideal, but also we have increasingly less Objective-C so it should be acceptable. Open to suggestions.
@jkmassel 's implementation had a build phase that downloaded the XCFrameworks sources. I omitted it and expect devs to run make dependencies before building the app. It felt a build phase was a bit too much, but it also feels like a line in the README to call attention to this is not enough. Open to suggestions.

Testing

I published this from the Simulator: https://giotestdotsite.wordpress.com/2025/01/07/via-gutenbegkit-without-cocoapods/ — Not sure if the HTML source can show it, but I did check locally that the experimental editor toggle was disabled. Besides, the UI being a bit different between the two helps being aware of it.

Apart from that, I'd say run the prototype build on device and see if the Gutenber-via-XCFramework editor works as expected.

Regression Notes

Potential unintended areas of impact

It's possible that some behavior in the Gutenber-XCFramework editor will be compromised. However, I don't see why, once the editor loads, all the code should be the same.

What I did to test those areas of impact (or what existing automated tests I relied on)

Had a go at publishing a post from the Simulator.

What automated tests I added (or what prevented me from doing so)

N.A.

PR submission checklist:

I have completed the Regression Notes.
I have considered adding unit tests for my changes. - N.A.
I have considered adding accessibility improvements for my changes. - N.A.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. - N.A.

Testing checklist:

That's for the value `CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER`, but it's useless to set `$(inherited)` for a Yes or No value because removing the value from the target will automatically make Xcode read it from the project, achieving the same result.

Was giving errors in Yoga: > Double-quoted include "YGEnums.h" in framework header, expected angle-bracketed instead

It resulted in a build failure: > React.framework/Headers/RCTAppearance.h:16:60: > A function declaration without a prototype is deprecated in all versions of C

dangermattic · 2025-01-07T06:54:18Z

	2 Warnings
⚠️	`Modules/Package.swift` was changed without updating its corresponding `Package.resolved`. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running `swift package resolve`).
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Strange that `pod deintegrate` did not remove it. Maybe it was some custom piece of setup...

As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install. See wordpress-mobile/WordPress-iOS#23951 which prompted this change.

We don't have pods anymore

wpmobilebot · 2025-01-07T08:01:50Z

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23951-c61cb2d
	Version	25.6
	Bundle ID	org.wordpress.alpha
	Commit	`c61cb2d`
	App Center Build	WPiOS - One-Offs #11289

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

We don't use Pods anymore

mokagio · 2025-01-07T08:15:27Z

WordPress/Classes/System/WordPressAppDelegate.swift

-        /// WordPressKit, now imported via CocoaPods, has the `AppExtension Safe API Only` flag set to *true*. Meaning that
-        /// the host app is, effectively as of now, responsible for presenting any alert onscreen (whenever a HTTP Challenge is
-        /// received). Capicci?
-        ///


This was a very old comment. It didn't seem to explain much to me, so I got rid of it.

mokagio · 2025-01-07T08:32:21Z

WordPressAuthenticator/Sources/Private/WPAuthenticator-Swift.h

-    #import "WordPressAuthenticator-Swift.h"
-#else
-    #import <WordPressAuthenticator/WordPressAuthenticator-Swift.h>
-#endif


This was only useful for the CocoaPods setup. I noticed it grepping for CocoaPods and removed it. There were only two usages anyway, which I updated to the generated header, see below.

wpmobilebot · 2025-01-07T08:33:10Z

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23951-c61cb2d
	Version	25.6
	Bundle ID	com.jetpack.alpha
	Commit	`c61cb2d`
	App Center Build	jetpack-installable-builds #10323

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

kean · 2025-01-07T15:18:44Z

I hope it'll merge with #23923. There wasn't anyone available to review stuff, so that's why there is this trunk #2.

As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install. See wordpress-mobile/WordPress-iOS#23951 which prompted this change.

mokagio · 2025-01-08T05:18:03Z

I hope it'll merge with #23923.

Love the christmas-feature-branch Nice work.

I'll try moving the changes there today.

mokagio · 2025-01-08T09:15:23Z

@kean seems like everything worked fine. See #23958 — There are CI failures, but look unrelated to the changes, as they match what's in the base branch, example https://buildkite.com/automattic/wordpress-ios/builds/25312

mokagio · 2025-01-08T10:07:37Z

There are CI failures, but look unrelated to the changes, as they match what's in the base branch, example buildkite.com/automattic/wordpress-ios/builds/25312

@kean I opened #23960 to start addressing them

mokagio · 2025-01-08T10:09:21Z

Closing in favor of #23958

As we start removing CocoaPods from some of our projects, we can no longer assume pods exist locally to install. See wordpress-mobile/WordPress-iOS#23951 which prompted this change.

mokagio added 13 commits January 6, 2025 17:41

Run pod deintegrate and remove CocoaPods automation

d04c009

Add Makefile automation to download Gutenberg framework

73242bf

Remove dead reference to Pods.framework in project

f1dca71

Remove dead reference to pods from workspace

0eb4bf5

Remove SwiftLint-via-CocoaPods from Rakefile

1035589

Remove CocoaPods instruction from the README

4af7363

Remove SwiftLint instructions from the README

4383c67

Add a version of Aztec fetched via SwiftPM

1d47e96

Add Gutenberg XCFrameworks via drag-n-drop from local paths

2fbd32d

Disable CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER

4a29aea

Was giving errors in Yoga: > Double-quoted include "YGEnums.h" in framework header, expected angle-bracketed instead

Disable CLANG_WARN_STRICT_PROTOTYPES

fbb0997

It resulted in a build failure: > React.framework/Headers/RCTAppearance.h:16:60: > A function declaration without a prototype is deprecated in all versions of C

Update search path for Gutenberg React Native bundle in script

785c6cc

mokagio added 3 commits January 7, 2025 08:03

Remove some leftover bits of CocoaPods set up for automation

450f968

Remove leftover COCOAPODS precompiler flag

250711e

Strange that `pod deintegrate` did not remove it. Maybe it was some custom piece of setup...

Remove a couple of CocoaPods-specific code branches

8720c7e

mokagio added 5 commits January 7, 2025 08:21

Temporarily switch to CI toolkit branch compatible with no CocoaPods

3111efa

Fetch XCFrameworks in CI

80df5af

Update Gutenberg checkout logic in localization lint for CP-less setup

cacf57e

Update source map upload for CP-less Gutenberg setup

f3bb122

Ensure Frameworks folder exist, otherwise tar will fail

13473f9

mokagio mentioned this pull request Jan 7, 2025

Only attempt to install pods when linting strings if CP is found Automattic/a8c-ci-toolkit-buildkite-plugin#136

Merged

1 task

Remove "Log Outdated Pods" step from code freeze

8e6ff0f

We don't have pods anymore

mokagio added 3 commits January 7, 2025 09:03

Remove Pods from lists in .gitignore and RuboCop

cd6946d

We don't use Pods anymore

Remove imports of Pods xcconfigs

56dfbce

No longer look in Pods folder to extract localizations

89884bd

mokagio mentioned this pull request Jan 7, 2025

Remove CocoaPods #23750

Closed

mokagio commented Jan 7, 2025

View reviewed changes

Link Gutenberg XCFramework in Jetpack target too!

b636e16

mokagio requested a review from jkmassel January 7, 2025 08:25

mokagio commented Jan 7, 2025

View reviewed changes

mokagio marked this pull request as ready for review January 7, 2025 08:40

Add instruction in README to run make dependencies

c61cb2d

mokagio added this to the 25.8 milestone Jan 7, 2025

mokagio added the Tooling Build, Release, and Validation Tools label Jan 7, 2025

mokagio mentioned this pull request Jan 8, 2025

Remove CocoaPods #23958

Merged

14 tasks

mokagio mentioned this pull request Jan 8, 2025

Address localization and test build failures #23960

Merged

mokagio closed this Jan 8, 2025

mokagio deleted the mokagio/gutenberg-via-xcframework branch January 8, 2025 10:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove CocoaPods#23951

Remove CocoaPods#23951
mokagio wants to merge 27 commits intotrunkfrom
mokagio/gutenberg-via-xcframework

mokagio commented Jan 7, 2025 •

edited

Loading

Uh oh!

dangermattic commented Jan 7, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 7, 2025 •

edited

Loading

Uh oh!

mokagio Jan 7, 2025

Uh oh!

mokagio Jan 7, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 7, 2025 •

edited

Loading

Uh oh!

kean commented Jan 7, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mokagio commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Regression Notes

Uh oh!

dangermattic commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mokagio Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

mokagio Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kean commented Jan 7, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

mokagio commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mokagio commented Jan 7, 2025 •

edited

Loading

dangermattic commented Jan 7, 2025 •

edited

Loading

wpmobilebot commented Jan 7, 2025 •

edited

Loading

mokagio Jan 7, 2025 •

edited

Loading

wpmobilebot commented Jan 7, 2025 •

edited

Loading