Skip to content

Fix bug in configure_apply action #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AliSoftware merged 2 commits into from
Nov 14, 2024
Merged

Fix bug in configure_apply action #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60948b4
Fix bug in `configure_apply` action
AliSoftware Nov 14, 2024
21671e5
Add CHANGELOG entry
AliSoftware Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ _None_

### Bug Fixes

_None_
- Fix bug in `configure_apply` that could happen if run on a user machine that hasn't yet `git-pull` the latest commits from `~/.mobile-secrets` to a commit _after_ the new encryption key had been pushed. [#612]

### Internal Changes

Expand All @@ -24,21 +24,21 @@ _None_

### Bug Fixes

- Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release` [#610]
- Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release`. [#610]
Copy link
Contributor

@mokagio mokagio Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅👍


## 12.3.0

### New Features

- `buildkite_pipeline_upload`: prepend `.buildkite/` to the `pipeline_file` parameter to enforce our conventions [#608]
- `buildkite_pipeline_upload`: prepend `.buildkite/` to the `pipeline_file` parameter to enforce our conventions. [#608]

### Bug Fixes

- `create_release-backmerge_pull_request`: Fix the pre-check logic verifying if a PR is really needed or if there's nothing to backmerge. [#607]

### Internal Changes

- `buildkite_pipeline_upload`: makes sure all values passed in the environment parameter are strings [#608]
- `buildkite_pipeline_upload`: makes sure all values passed in the environment parameter are strings. [#608]

## 12.2.1

Expand Down
5 changes: 2 additions & 3 deletions lib/fastlane/plugin/wpmreleasetoolkit/actions/configure/configure_apply_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,10 @@ module Fastlane
module Actions
class ConfigureApplyAction < Action
def self.run(params = {})
# Preflight
UI.user_error!('Decryption key could not be found') if Fastlane::Helper::ConfigureHelper.encryption_key.nil?

# Checkout the right commit hash etc. before applying the configuration
prepare_repository do
UI.user_error!('Decryption key could not be found') if Fastlane::Helper::ConfigureHelper.encryption_key.nil?

# Copy/decrypt the files
files_to_copy.each do |file_reference|
apply_file(file_reference, params[:force])
Expand Down