Fix bug in configure_apply action
#612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new encryption key is recently added and pushed to `~/.mobile-secrets` by one developer, other developers will likely not yet have their own `~/.mobile-secrets` repo pulled to that latest commit that includes the new encryption key. This means that in those scenarios, after a new project is set up for `configure` and a new encryption key is added, any other developer who would be told to "please now run `bundle exec fastlane run configure_apply`" will have the command fail, because on their local machine their `~/.mobile-secrets` would not yet have the new encryption key, and the preflight test we did about this at the start of the action would error early. The fix is easy: make sure we only check for the presence of the encryption key _after_ we have entered the `prepare_repository` block and thus pulled and checked out the correct commit of `~/.mobile-secrets` first.
mokagio
approved these changes
Nov 14, 2024
Contributor
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Looks good.
I'd love to have tests for this but it seems like an integration test with various moving parts that would go beyond the scope of this fix PR.
| ### Bug Fixes | ||
|
|
||
| - Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release` [#610] | ||
| - Fix issue with post-processing of PR urls in the body of GitHub releases created via `create_github_release`. [#610] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
When a new encryption key is recently added and pushed to
~/.mobile-secretsby one developer, other developers will likely not yet have their own~/.mobile-secretsrepo pulled to that latest commit that includes the new encryption key.This means that in those scenarios, after a new project is set up for
configureand a new encryption key is added, any other developer who would be told to "please now runbundle exec fastlane run configure_apply" will have the command fail, because on their local machine their~/.mobile-secretswould not yet have the new encryption key, and the preflight test we did about this at the start of the action would error early.The fix is easy: make sure we only check for the presence of the encryption key after we have entered the
prepare_repositoryblock and thus pulled and checked out the correct commit of~/.mobile-secretsfirst.Related conversation: p1731606985135599/1731586195.925939-slack-C04PWEZSYFL
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendationsspecs/*_spec.rb) if applicablebundle exec rspecto run the whole test suite and ensure all your tests passCHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.