Skip to content

evm: fix test_transceiverIncompatibleNttManager #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

evm: fix test_transceiverIncompatibleNttManager #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion evm/test/NttManager.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import "./mocks/DummyTransceiver.sol";
import "../src/mocks/DummyToken.sol";
import "./mocks/MockNttManager.sol";

contract DummyManager {}

// TODO: set this up so the common functionality tests can be run against both
contract TestNttManager is Test, IRateLimiterEvents {
MockNttManagerContract nttManager;
Expand Down Expand Up @@ -333,8 +335,9 @@ contract TestNttManager is Test, IRateLimiterEvents {

function test_transceiverIncompatibleNttManager() public {
// Transceiver instantiation reverts if the nttManager doesn't have the proper token method
address dummyManager = address(new DummyManager());
vm.expectRevert(bytes(""));
new DummyTransceiver(address(0xBEEF));
new DummyTransceiver(dummyManager);
}

function test_transceiverWrongNttManager() public {
Expand Down
6 changes: 0 additions & 6 deletions evm/test/NttManagerNoRateLimiting.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,6 @@ contract TestNttManagerNoRateLimiting is Test, IRateLimiterEvents {
nttManager.setTransceiver(address(e2));
}

function test_transceiverIncompatibleNttManagerNoRateLimiting() public {
// Transceiver instantiation reverts if the nttManager doesn't have the proper token method
vm.expectRevert(bytes(""));
new DummyTransceiver(address(0xBEEF));
}

function test_transceiverWrongNttManagerNoRateLimiting() public {
// TODO: this is accepted currently. should we include a check to ensure
// only transceivers whose nttManager is us can be registered? (this would be
Expand Down
Loading