Skip to content

Conversation

@colinmurphy
Copy link
Member

  1. Removed scroll-overflow class to fix sidebar
  2. Removed loading text as it was displaying on pages where there was no headings
  3. Added breadcrumb back in for /docs

1. Removed scroll-overflow class to fix sidebar
2. Removed loading text as it was displaying on pages where there was no headings
3. Added breadcrumb back in for /docs
@colinmurphy colinmurphy marked this pull request as ready for review January 27, 2025 18:25
@colinmurphy colinmurphy mentioned this pull request Jan 27, 2025
3 tasks
@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-doc-page-issues https://hz…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister
Copy link
Member

Looking better! 2 issues left I'm seeing

  1. The top margin/padding on docs content pushes the breadcrumbs way below the level of the top of the left nav and right "on this page." Should those all be the same height?
  2. On doc pages with lots of content you have to scroll to the bottom of the page to see the bottom of the docs nav on the left. It should have its own scroll bars separate from the page.

Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. Fixed vertical height of the docs content

2. Added a vetical scroll to the left hand sidebar
@colinmurphy
Copy link
Member Author

Thanks @moonmeister

I have pushed a fix for both issues there. Please review and thanks for the feedback 👍

@headless-platform-by-wp-engine

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-bug-fix-doc-page-issues https://hz…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

@moonmeister moonmeister merged commit d616e23 into toolkit Jan 28, 2025
4 checks passed
@moonmeister moonmeister deleted the bug-fix-doc-page-issues branch January 28, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants