Skip to content

Various fixes #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moonmeister merged 2 commits into from
Jan 28, 2025
Merged

Various fixes #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e90301
Various fixes
colinmurphy Jan 27, 2025
60521ad
Various fixes
colinmurphy Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/docs-breadcrumbs.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,18 @@ export default function DocsBreadcrumbs({ routes }) {
const currentPath = router.pathname;
const breadcrumbLinks = generateBreadcrumbs(routes, currentPath);

if (breadcrumbLinks.length === 0 || currentPath === "/docs") {
if (breadcrumbLinks.length === 0) {
return;
}

const homeRoute = routes[0];
homeRoute.title = "Docs";
breadcrumbLinks.unshift(homeRoute);

if (currentPath === "/docs") {
breadcrumbLinks.shift(0);
}

return (
<div className="mt-4 mb-7 md:mt-2 md:mb-10">
<div className="flex flex-wrap items-center gap-2 text-sm">
Expand Down
8 changes: 4 additions & 4 deletions src/components/docs-layout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ export default function DocumentPage({ children, metadata }) {
/>
</DisclosurePanel>
</Disclosure>
<main className="relative mx-auto flex max-w-full grid-cols-[1fr_auto_1fr] flex-col gap-6 overflow-scroll md:grid">
<nav className="sticky top-[84px] hidden h-min w-60 overflow-y-auto p-6 md:block">
<main className="relative mx-auto flex max-w-full grid-cols-[1fr_auto_1fr] flex-col gap-6 md:grid">
<nav className="sticky top-[84px] hidden h-[calc(100vh-84px)] w-60 overflow-y-auto p-6 md:block">
<DocsNav routes={routes} />
</nav>
<nav className="sticky top-[84px] order-last hidden h-min w-[240px] overflow-y-auto p-6 lg:block">
<nav className="sticky top-[84px] order-last hidden h-[calc(100vh-84px)] w-[240px] overflow-y-auto p-6 lg:block">
<OnThisPageNav>{children}</OnThisPageNav>
</nav>
<article className="container-main xs:py-20 prose prose-invert min-h-[calc(100vh-120px)] max-w-full py-0 sm:max-w-[80ch] sm:py-20 md:py-24">
<article className="container-main xs:py-20 prose prose-invert min-h-[calc(100vh-120px)] max-w-full py-0 sm:max-w-[80ch] sm:py-20 md:py-8">
<DocsBreadcrumbs routes={flatRoutes} />
{metadata?.title && (
<h1 className="article-title break-words">{metadata.title}</h1>
Expand Down
6 changes: 2 additions & 4 deletions src/components/on-this-page-nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export default function OnThisPageNav({ children }) {

return (
<>
<h2 className="font-semibold">On This Page</h2>
{headings.length > 0 ? (
<h2 className="py-2 font-semibold">On This Page</h2>
{headings.length > 0 && (
<ul className="mt-4 text-sm text-gray-400">
{headings.map((heading) => (
<li
Expand All @@ -68,8 +68,6 @@ export default function OnThisPageNav({ children }) {
</li>
))}
</ul>
) : (
<p>Loading...</p>
)}
</>
);
Expand Down
Loading