Skip to content

Conversation

@theodesp
Copy link
Member

@theodesp theodesp commented Jan 23, 2025

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Faustwp: Set php min version to v7.4

Related Issue(s):

#2022

Testing

Screenshots

Documentation Changes

Dependant PRs

@theodesp theodesp requested a review from a team as a code owner January 23, 2025 10:25
@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 9e7d69a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

*
* @return string Minimum version required.
*/
function faustwp_minimum_php_requirement() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to suggest to have only one place for specifying the min php version - in plugin's header. That will allow us to edit min php version only once, and move the functionality into a standalone class in future. We can use get_plugins or get_file_data or get_plugins_data... But I am not sure how relevant it is now, maybe a good thing to keep in mind for future

@theodesp theodesp requested a review from whoami-pwd January 24, 2025 11:34
@theodesp theodesp merged commit 820705a into canary Jan 27, 2025
17 checks passed
@theodesp theodesp deleted the faustwp-set-min-php-7.4 branch January 27, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants