Skip to content

chore: update plugin php min version to 7.4 #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theodesp merged 4 commits into from
Jan 27, 2025
Merged

chore: update plugin php min version to 7.4 #2035

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
240261e
chore: update plugin php min version to 7.4
theodesp Jan 23, 2025
9e7d69a
feat: add admin notices for min php version
theodesp Jan 23, 2025
5a29702
refactor: code review update
theodesp Jan 23, 2025
639acb6
refactor: use build-in is_php_version_compatible
theodesp Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/faustwp/faustwp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ function faustwp_minimum_php_requirement() {
*
* @return bool True if meets minimum requirements, false otherwise.
*/
function faustwp_meets_php_requirements() {
function is_php_version_compatible() {
return version_compare( phpversion(), faustwp_minimum_php_requirement(), '>=' );
}

if ( ! faustwp_meets_php_requirements() ) {
if ( ! is_php_version_compatible() ) {
add_action(
'admin_notices',
function () {
Expand All @@ -59,7 +59,7 @@ function () {
printf(
/* translators: %s: Minimum required PHP version */
esc_html__( 'FaustWP requires PHP version %s or later. Please upgrade PHP or disable the plugin.', 'faustwp' ),
esc_html( faustwp_meets_php_requirements() )
esc_html( is_php_version_compatible() )
);
?>
</p>
Expand Down
Loading