docs: explanation on which queries to use #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodesp
changed the title
josephfusco
previously approved these changes
Mar 18, 2025
moonmeister
requested changes
Mar 18, 2025
Member
There was a problem hiding this comment.
Looks good. I find it a little odd that in Faust we use ?graphql but here we recommend /graphql. I've reworked a couple sections to clearly outline benefits of either without strongly recommending one or the other. Feel free to take these suggestions as-is or rework them as you see fit.
Member
|
can we also rename this to something like |
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
Co-authored-by: Alex Moon <[email protected]>
josephfusco
approved these changes
Mar 19, 2025
Member
josephfusco
left a comment
josephfusco
left a comment
There was a problem hiding this comment.
This reads well @theodesp 🙌🏼
Member
|
@theodesp Great PR for docs. Very easy to read and understand ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#52