[wpical] Allow use of other ChArUco dictionaries for camera calibration #7987
+65
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
requested changes
May 24, 2025
Co-authored-by: Tyler Veness <[email protected]>
calcmogul
reviewed
May 24, 2025
|
You can ignore the RobotPy build failure. The build system changed upstream and we haven't updated CI to match yet. |
|
That MacOS build failure doesn’t seem relevant to this PR. |
|
Bumping this to get reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, WPICal only lets you use the 5x5 1000 markers ChArUco dictionary for calibrating your camera. This PR allows you set what dictionary is used via a drop-down menu. This menu defaults to
DICT_5X5_1000which is what was used in the previous version. There is also a tool tip when hovering over the drop-down that indicates to only change the selection if you know what you're doing. I don't particularly like my current implementation (I am not an experienced C++ developer) and am open to suggestions on how to improve it. I have also updated the tests accordingly.