[lint] Update buildifier #8060
Open
[lint] Update buildifier #8060
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
reviewed
Jul 3, 2025
| id: go | ||
|
|
||
| - name: Install Buildifier | ||
| run: | | ||
| cd $(mktemp -d) | ||
| GO111MODULE=on go get github.com/bazelbuild/buildtools/buildifier@6.0.0 | ||
| GO111MODULE=on go install github.com/bazelbuild/buildtools/buildifier@v0.0.0-20250703141324-fdc626802fbc |
There was a problem hiding this comment.
Is it typical to run pre-release versions like this locally?
There was a problem hiding this comment.
I have no idea how go install works, but it wouldn't find 8.2.1. When I locally ran the instructions from the buildifier docs, that was the version that got spit out
There was a problem hiding this comment.
Also if you run go install github.com/bazelbuild/buildtools/[email protected] it prints out that it installed v0.0.0-20230109211708-de1a539b56e7
There was a problem hiding this comment.
Should we use the pre-built binaries instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that me an Austin both seem to have more recent version of buildifier locally which is causing extraneous changes in our PR's. This updates it to the latest version as of today.