-
Notifications
You must be signed in to change notification settings - Fork 665
Update templates to cancel the auto command in AutononmousExit #8090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think canceling should work in autonomousExit, but you wouldn't want to do more like start a new command (that doesn't run when disabled) in autonomousExit, since the robot is disabled at that point. |
I agree, I think all the templates should still override |
I added back |
With my changes, the only things the templates do on |
@PeterJohnson I'm not sure how do I get one of the WPILib maintainers to look at this. Could you help? |
If someone's reviewed already, you can usually just re-request their review in GitHub. If that hasn't happened yet (like this this case), usually it comes down to either asking here on GitHub or in the programming channels of the unofficial FRC Discord server. I will note that things have been fairly busy for the last few months with preparations for the 2027 SystemCore changes, and stuff like updating templates can fall through the cracks of reviewing a bit more easily. However, people seem to still be fairly good at reviewing once reminded. (For what it's worth as someone who's not an actual WPILib maintainer, the changes seem fine to me. You may want to rebase, though, since it's been so long.) |
a6f31d1
to
ff89277
Compare
This change updates the templates that included code that canceled autonomous commands in TeleopInit() to instead cancel them in AutonomousExit(). While in a real competition teleop mode starts after autonomous mode ends, when using the simulator the user can change modes in any order. Commands scheduled in AutonomousInit() should therefore be canceled in AutonomousExit().
ff89277
to
be46e4c
Compare
This change updates the templates that included code that canceled autonomous commands in TeleopInit() to instead cancel them in AutonomousExit().
While in a real competition teleop mode starts after autonomous mode ends, when using the simulator the user can change modes in any order. Commands scheduled in AutonomousInit() should therefore be canceled in AutonomousExit().