Allow .Until(Trigger()) in C++ #8106
Open
+28
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component: command-based
| * | ||
| * @return A std::function<bool()> representing the condition of this trigger. | ||
| */ | ||
| operator std::function<bool()>() const { return m_condition; } |
There was a problem hiding this comment.
Nit: I'd move this below Debounce() (probably under Get() too), since operator&&, operator||, operator!(), and Debounce() are all methods that create different Triggers, but this defines a conversion into a different type. (In other words, Debounce() is more similar to the other operators than the conversion operator is.)
KangarooKoala
approved these changes
Jul 22, 2025
|
Could the macOS check fail just be due to resources being busy? If so, can someone re-run please? |
wpilibNewCommands/src/main/native/include/frc2/command/button/Trigger.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Eng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8031
Define operator std::function<bool()>() in Trigger, allowing implicit conversions from Trigger to std::function<bool()>. This is primarily so triggers can be used in command decorators like .Until().