Add reset() for Debouncer #8111
Open
+75
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds reset() option to clear internal state of debouncer - Java only for now, I don't know optional equivalent in C++ - Is reset() a good name for this? - Is more explanation needed in the javadoc?
- I just learned that you can run the same command as the action to make sure it doesn't fail again. The more you know...
Generally I've seen people open PRs into their branch (which just involves changing the base branch when you create the PR), but this should hopefully be okay. |
MichaelLesirge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset method for Debouncer class
closes #8086
Adds a C++ version of the reset method to the Debouncer class. Java version written by @therekrab.