[wpiunits] Make measure implementations immutable only#8115
Merged
PeterJohnson merged 1 commit intowpilibsuite:2027from Jul 26, 2025
Merged
[wpiunits] Make measure implementations immutable only#8115PeterJohnson merged 1 commit intowpilibsuite:2027from
PeterJohnson merged 1 commit intowpilibsuite:2027from
Conversation
Remove mutable implementations, as systemcore doesn't need mutability to keep performance under control
Contributor
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
github-actions
bot
added
component: command-based
PeterJohnson
approved these changes
Jul 25, 2025
Member
|
Should the title be "Make measure implementations immutable only"? |
PeterJohnson
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove mutable implementations, as systemcore doesn't need mutability to keep performance under control