[bazel] Add sugar wrappers for halsim extensions #8165
Conversation
| ) | ||
|
|
||
| wpilib_cc_static_library( | ||
| name = "static/{}".format(name), |
There was a problem hiding this comment.
Even after reading the docstring I'm confused what the difference between :static/foo and :foo_static are meant to be, given they have the same visibility.
There was a problem hiding this comment.
Naming can probably be improved. The idea is as follows:
When you build a static extension, nothing special needs to happen. When you are building a dynamic halsim extension, you need "-DHALSIM_InitExtension=" + static_init_extension_name, to define some special symbols to help load the shared library. To do that, you need to build the code twice, once without the define, another time with.
I bet we could mark the _static version as private.
|
Once @auscompgeek 's comment is addressed, I'm happy with this and happy to approve. |
Actually @AustinSchuh could you provide more info there? You are the one who added those static versions if you could give the comment more color. |
This should simplify the creation and maintenance of halsim libraries. The macro has been updated to build all of the different flavors that have been set up and greatly reduces the duplication.