Skip to content

Comments

Move robot base classes from opmode to framework#8344

Merged
PeterJohnson merged 1 commit intowpilibsuite:2027from
PeterJohnson:move-robot-base-classes
Nov 8, 2025
Merged

Move robot base classes from opmode to framework#8344
PeterJohnson merged 1 commit intowpilibsuite:2027from
PeterJohnson:move-robot-base-classes

Conversation

@PeterJohnson
Copy link
Member

Having these in opmode will be confusing to users when opmodes are added.

Having these in opmode will be confusing to users when opmodes are added.
@PeterJohnson PeterJohnson requested review from a team as code owners November 8, 2025 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@github-actions github-actions bot added component: wpilibj WPILib Java component: wpilibc WPILib C++ component: command-based WPILib Command Based Library component: examples component: epilogue Annotation-based logging library 2027 2027 target labels Nov 8, 2025
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me, for what it's worth. grep and find say this got all of the instances of opmode:

% git fetch upstream pull/8344/head && git checkout --detach FETCH_HEAD && grep -r 'opmode' . && find . -path '*opmode*'
From https://github.com/wpilibsuite/allwpilib
 * branch                  refs/pull/8344/head -> FETCH_HEAD
HEAD is now at 3566b71202 Move robot base classes from opmode to framework

@PeterJohnson PeterJohnson merged commit 18efd1e into wpilibsuite:2027 Nov 8, 2025
34 of 35 checks passed
@PeterJohnson PeterJohnson deleted the move-robot-base-classes branch November 8, 2025 23:08
@KangarooKoala
Copy link
Contributor

Seems alright to me, for what it's worth. grep and find say this got all of the instances of opmode:

% git fetch upstream pull/8344/head && git checkout --detach FETCH_HEAD && grep -r 'opmode' . && find . -path '*opmode*'
From https://github.com/wpilibsuite/allwpilib
 * branch                  refs/pull/8344/head -> FETCH_HEAD
HEAD is now at 3566b71202 Move robot base classes from opmode to framework

... I'm not sure how I got that output. Rerunning it shows that the source files were missed:

% git fetch upstream pull/8344/head && git checkout --detach FETCH_HEAD && grep -r 'opmode' . && find . -path '*opmode*'
From https://github.com/wpilibsuite/allwpilib
 * branch                  refs/pull/8344/head -> FETCH_HEAD
HEAD is now at 3566b71202 Move robot base classes from opmode to framework
Binary file ./.gradle/8.14.3/nativeCompile/nativeCompile.bin matches
Binary file ./.gradle/8.14.3/executionHistory/executionHistory.bin matches
./wpilibc/src/main/native/cpp/opmode
./wpilibc/src/main/native/cpp/opmode/RobotState.cpp
./wpilibc/src/main/native/cpp/opmode/TimesliceRobot.cpp
./wpilibc/src/main/native/cpp/opmode/TimedRobot.cpp
./wpilibc/src/main/native/cpp/opmode/IterativeRobotBase.cpp

@rzblue rzblue mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2027 2027 target component: command-based WPILib Command Based Library component: epilogue Annotation-based logging library component: examples component: wpilibc WPILib C++ component: wpilibj WPILib Java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants