Move robot base classes from opmode to framework#8344
Merged
PeterJohnson merged 1 commit intowpilibsuite:2027from Nov 8, 2025
Merged
Move robot base classes from opmode to framework#8344PeterJohnson merged 1 commit intowpilibsuite:2027from
PeterJohnson merged 1 commit intowpilibsuite:2027from
Conversation
Having these in opmode will be confusing to users when opmodes are added.
Contributor
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
KangarooKoala
approved these changes
Nov 8, 2025
Contributor
KangarooKoala
left a comment
There was a problem hiding this comment.
Seems alright to me, for what it's worth. grep and find say this got all of the instances of opmode:
% git fetch upstream pull/8344/head && git checkout --detach FETCH_HEAD && grep -r 'opmode' . && find . -path '*opmode*'
From https://github.com/wpilibsuite/allwpilib
* branch refs/pull/8344/head -> FETCH_HEAD
HEAD is now at 3566b71202 Move robot base classes from opmode to framework
Contributor
... I'm not sure how I got that output. Rerunning it shows that the source files were missed: |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having these in opmode will be confusing to users when opmodes are added.