[wpimath, wpiutil]: Specify that java_multiple_files is true in Protobuf files and regenerate#8555
[wpimath, wpiutil]: Specify that java_multiple_files is true in Protobuf files and regenerate#8555cswilson252 wants to merge 15 commits intowpilibsuite:2027from
Conversation
…buf files and regenerate files
wpimath/src/generated/main/native/cpp/wpimath/protobuf/controller.npb.cpp
Show resolved
Hide resolved
|
For the aid of other reviewers, I could run the below commands in zsh on 75d0211 without any output from ( |
|
This should probably also set the outer class name, since that's what the original issue was about. Probably want to call it something like |
the outer class name of the |
|
The Java generated files. I really don’t want to see protobuf_name_descriptor.h in includes. |
Gold856
left a comment
There was a problem hiding this comment.
Use option java_outer_classname in the .proto file to rename the classes. You'll have to use a name other than a Protobuf prefix because of the name conflict with ProtobufTrajectory. Protobuf<Name>Descriptor is probably fine. Also, resolve all merge conflicts.
…buf files and regenerate files
…son252/allwpilib into javaMultipleProtobufAttrib
|
ok this PR is kinda broken again 😭 on to v3 I guess. thanks a lot #8468 |
|
You'll need to delete the old generated Java protobuf files (e.g., |
done! |
Closes #8256