Skip to content

[romi, xrp]: Show DS connection info on HAL initialisation#8560

Open
cswilson252 wants to merge 31 commits intowpilibsuite:2027from
cswilson252:romiConnectionInfoOnStartup
Open

[romi, xrp]: Show DS connection info on HAL initialisation#8560
cswilson252 wants to merge 31 commits intowpilibsuite:2027from
cswilson252:romiConnectionInfoOnStartup

Conversation

@cswilson252
Copy link
Copy Markdown
Contributor

Closes #6352

@cswilson252 cswilson252 requested a review from a team as a code owner January 11, 2026 03:35
@github-actions github-actions bot added the 2027 2027 target label Jan 11, 2026
Copy link
Copy Markdown
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to do what it says on the tin; specifically this doesn't print on HAL initialisation, but on instantiation of a gyro object instead.

@cswilson252
Copy link
Copy Markdown
Contributor Author

This doesn't seem to do what it says on the tin; specifically this doesn't print on HAL initialisation, but on instantiation of a gyro object instead.

I was wondering where to put the console prints; I only realized that having them in the gyro constructor might not be the best idea as I was debugging the last couple of CI fails. I'll move them so they print on initialisation.

@cswilson252 cswilson252 requested review from a team and PeterJohnson as code owners February 11, 2026 22:45
@github-actions github-actions bot added component: ntcore NetworkTables library component: wpiutil Utility library component: wpilibj WPILib Java component: wpilibc WPILib C++ labels Feb 11, 2026
@auscompgeek
Copy link
Copy Markdown
Member

Couldn't figure out the Romi equivalent to this in the simulation/ folder :(

Yeah I had to look up how that works again. Romi connects using halsim-ws-client apparently.

@auscompgeek auscompgeek removed request for a team and PeterJohnson February 21, 2026 06:32
@cswilson252
Copy link
Copy Markdown
Contributor Author

builds successfully!!

@Gold856 Gold856 linked an issue Feb 22, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Member

@Gold856 Gold856 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't feel like DS connection info? I'm not actually sure what the original issue was asking for.

@cswilson252
Copy link
Copy Markdown
Contributor Author

This doesn't feel like DS connection info? I'm not actually sure what the original issue was asking for.

yeah, I might've phrased the original PR title wrong? I'm pretty sure that the issue is just asking for "something to print to the DS when a Romi/XRP is started to show that HAL exists" 🤷‍♀️

@ThadHouse
Copy link
Copy Markdown
Member

That print will essentially always be false, because outputs won't be enabled until after initialization.

I'm gonna go with Gold here, I'm not actually sure what this should do.

@virtuald
Copy link
Copy Markdown
Member

This PR's current content has nothing to do with what the linked issue is attempting to describe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2027 2027 target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XRP/ROMI should print out connection information at startup

6 participants