[romi, xrp]: Show DS connection info on HAL initialisation#8560
Open
cswilson252 wants to merge 15 commits intowpilibsuite:2027from
Open
[romi, xrp]: Show DS connection info on HAL initialisation#8560cswilson252 wants to merge 15 commits intowpilibsuite:2027from
cswilson252 wants to merge 15 commits intowpilibsuite:2027from
Conversation
auscompgeek
reviewed
Jan 11, 2026
|
|
||
| #include <fmt/std.h> | ||
|
|
||
| #include "string" |
Member
There was a problem hiding this comment.
C++ standard library includes should use <>.
auscompgeek
requested changes
Jan 11, 2026
Member
auscompgeek
left a comment
auscompgeek
left a comment
There was a problem hiding this comment.
This doesn't seem to do what it says on the tin; specifically this doesn't print on HAL initialisation, but on instantiation of a gyro object instead.
Contributor
Author
I was wondering where to put the console prints; I only realized that having them in the gyro constructor might not be the best idea as I was debugging the last couple of CI fails. I'll move them so they print on initialisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6352