[romi, xrp]: Show DS connection info on HAL initialisation#8560
[romi, xrp]: Show DS connection info on HAL initialisation#8560cswilson252 wants to merge 31 commits intowpilibsuite:2027from
Conversation
auscompgeek
left a comment
There was a problem hiding this comment.
This doesn't seem to do what it says on the tin; specifically this doesn't print on HAL initialisation, but on instantiation of a gyro object instead.
I was wondering where to put the console prints; I only realized that having them in the gyro constructor might not be the best idea as I was debugging the last couple of CI fails. I'll move them so they print on initialisation. |
Yeah I had to look up how that works again. Romi connects using halsim-ws-client apparently. |
Co-authored-by: Tyler Veness <calcmogul@gmail.com>
|
builds successfully!! |
Gold856
left a comment
There was a problem hiding this comment.
This doesn't feel like DS connection info? I'm not actually sure what the original issue was asking for.
yeah, I might've phrased the original PR title wrong? I'm pretty sure that the issue is just asking for "something to print to the DS when a Romi/XRP is started to show that HAL exists" 🤷♀️ |
|
That print will essentially always be false, because outputs won't be enabled until after initialization. I'm gonna go with Gold here, I'm not actually sure what this should do. |
|
This PR's current content has nothing to do with what the linked issue is attempting to describe. |
Closes #6352