Skip to content

[romi, xrp]: Show DS connection info on HAL initialisation #8560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cswilson252 wants to merge 15 commits into
base: 2027
Choose a base branch
from
Open

[romi, xrp]: Show DS connection info on HAL initialisation #8560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
00819f4
java
cswilson252 Jan 11, 2026
f0f8e9c
cpp
cswilson252 Jan 11, 2026
e6e9bc3
oh so thats why the other imports are like that
cswilson252 Jan 11, 2026
ae61d0d
use the normal print library
cswilson252 Jan 11, 2026
45b8982
change header name
cswilson252 Jan 11, 2026
5922082
proper import
cswilson252 Jan 11, 2026
1a32d6f
change import namespace from frc to wpi
cswilson252 Jan 11, 2026
6c47834
expand GetName
cswilson252 Jan 11, 2026
9377218
i dont like c++
cswilson252 Jan 11, 2026
6b51127
idk
cswilson252 Jan 11, 2026
3bbe5db
try with new namespace
cswilson252 Jan 11, 2026
92d96ff
...
cswilson252 Jan 11, 2026
a9a0058
delete semicolon
cswilson252 Jan 11, 2026
542889e
change to instance function
cswilson252 Jan 11, 2026
036fb4b
print within null check
cswilson252 Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions romiVendordep/src/main/java/org/wpilib/romi/RomiGyro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

package org.wpilib.romi;

import org.wpilib.driverstation.DriverStation;
import org.wpilib.hardware.hal.SimDevice;
import org.wpilib.hardware.hal.SimDevice.Direction;
import org.wpilib.hardware.hal.SimDouble;
Expand Down Expand Up @@ -39,6 +40,10 @@ public RomiGyro() {
m_simAngleX = m_simDevice.createDouble("angle_x", Direction.kInput, 0.0);
m_simAngleY = m_simDevice.createDouble("angle_y", Direction.kInput, 0.0);
m_simAngleZ = m_simDevice.createDouble("angle_z", Direction.kInput, 0.0);

System.out.println("Name of connected device: " + m_simDevice.getName());
System.out.println("Robot Enable Status: " + DriverStation.isEnabled());
System.out.println("E-Stop Status: " + DriverStation.isEStopped());
} else {
m_simRateX = null;
m_simRateY = null;
Expand Down
8 changes: 8 additions & 0 deletions romiVendordep/src/main/native/cpp/romi/RomiGyro.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@

#include "wpi/romi/RomiGyro.hpp"

#include <fmt/std.h>

#include "string"
Copy link
Member

@auscompgeek auscompgeek Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ standard library includes should use <>.

#include "wpi/driverstation/DriverStation.hpp"

using namespace wpi::romi;

RomiGyro::RomiGyro() : m_simDevice("Gyro:RomiGyro") {
Expand All @@ -22,6 +27,9 @@ RomiGyro::RomiGyro() : m_simDevice("Gyro:RomiGyro") {
m_simAngleZ =
m_simDevice.CreateDouble("angle_z", hal::SimDevice::kInput, 0.0);
}
fmt::print("Name of connected device: {}\n", m_simDevice.GetName());
fmt::print("Robot Enable Status: {}\n", wpi::DriverStation::IsEnabled());
fmt::print("E-Stop Status: {}\n", wpi::DriverStation::IsEStopped());
}

wpi::units::radian_t RomiGyro::GetAngle() const {
Expand Down
5 changes: 5 additions & 0 deletions xrpVendordep/src/main/java/org/wpilib/xrp/XRPGyro.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

package org.wpilib.xrp;

import org.wpilib.driverstation.DriverStation;
import org.wpilib.hardware.hal.SimDevice;
import org.wpilib.hardware.hal.SimDevice.Direction;
import org.wpilib.hardware.hal.SimDouble;
Expand Down Expand Up @@ -44,6 +45,10 @@ public XRPGyro() {
m_simAngleX = m_simDevice.createDouble("angle_x", Direction.kInput, 0.0);
m_simAngleY = m_simDevice.createDouble("angle_y", Direction.kInput, 0.0);
m_simAngleZ = m_simDevice.createDouble("angle_z", Direction.kInput, 0.0);

System.out.println("Name of connected device: " + m_simDevice.getName());
System.out.println("Robot Enable Status: " + DriverStation.isEnabled());
System.out.println("E-Stop Status: " + DriverStation.isEStopped());
} else {
m_simRateX = null;
m_simRateY = null;
Expand Down
7 changes: 7 additions & 0 deletions xrpVendordep/src/main/native/cpp/xrp/XRPGyro.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

#include "wpi/xrp/XRPGyro.hpp"

#include <fmt/std.h>

#include "string"
#include "wpi/driverstation/DriverStation.hpp"
#include "wpi/units/angle.hpp"
#include "wpi/units/angular_velocity.hpp"

Expand All @@ -25,6 +29,9 @@ XRPGyro::XRPGyro() : m_simDevice("Gyro:XRPGyro") {
m_simAngleZ =
m_simDevice.CreateDouble("angle_z", hal::SimDevice::kInput, 0.0);
}
fmt::print("Name of connected device: {}\n", m_simDevice.GetName());
fmt::print("Robot Enable Status: {}\n", wpi::DriverStation::IsEnabled());
fmt::print("E-Stop Status: {}\n", wpi::DriverStation::IsEStopped());
}

wpi::units::radian_t XRPGyro::GetAngle() const {
Expand Down
Loading