Update to SDL joystick mappings from 1-19-2026#8593
Update to SDL joystick mappings from 1-19-2026#8593sciencewhiz wants to merge 2 commits intowpilibsuite:2027from
Conversation
| #ifdef __GNUC__ | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wpedantic" | ||
| #endif |
There was a problem hiding this comment.
Why has this suppression added by upstream_utils/glfw_patches/0001-Suppress-Compiler-Warnings.patch been removed?
There was a problem hiding this comment.
Looks like the glfw script to update the file just overwrites everything, so that patch should be applied again after running the script.
But since It builds, I'm wondering if that portion of the patch is still necessary. @pjreiniger any recollection if that was for older gcc versions which would be OBE in 2027, or newer versions?
There was a problem hiding this comment.
No idea.
I'm pretty sure that whenever I made something upstream_utils-able I strove to make it match exactly what was already in the repository. That might be super old and not necessary anymore
There was a problem hiding this comment.
I didn't see it in https://github.com/wpilibsuite/thirdparty-imgui which is what made me think you added it to get it to build on the import to upstream_utils.
There was a problem hiding this comment.
I added another patch to put in in the input file.
There was a problem hiding this comment.
That patch should probably be reordered to be the first patch right?
3 participants
Fixes #8103