Make RPM an alias of RotationsPerMinute#8595
Open
gavinskycastle wants to merge 3 commits intowpilibsuite:mainfrom
Open
Make RPM an alias of RotationsPerMinute#8595gavinskycastle wants to merge 3 commits intowpilibsuite:mainfrom
gavinskycastle wants to merge 3 commits intowpilibsuite:mainfrom
Conversation
KangarooKoala
suggested changes
Jan 26, 2026
Contributor
KangarooKoala
left a comment
KangarooKoala
left a comment
There was a problem hiding this comment.
Nice change! I'm not an official WPILib maintainer, but this seems like a nice QOL improvement.
Also, thanks for checking whether C++ also needs to be modified! C++ units and Java units are extremely different, so most changes to one won't apply to the other, but it's still awesome that you double-checked.
Contributor
|
The Java format and wpiformat CI logs are saying that you need to remove the whitespace on the blank line between |
KangarooKoala
approved these changes
Feb 2, 2026
Contributor
KangarooKoala
left a comment
KangarooKoala
left a comment
There was a problem hiding this comment.
Seems generally alright to me, but you'll need approval from an official WPILib maintainer.
SamCarlberg
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only name for this unit is
RPM. This caused a bit of confusion for a couple of my team members when we failed to find an RPM unit, assuming it would be namedRotationsPerMinuteas is the standard for almost all other units, such asRotationsPerSecond.No corresponding changes have been made to wpilibc as it seems to already work this way, with
rpmbeing the abbreviation forrevolutions_per_minute.