[cmd] Fix WaitUntilCommand for match time counting down#8632
Merged
PeterJohnson merged 2 commits intowpilibsuite:mainfrom Feb 24, 2026
Merged
[cmd] Fix WaitUntilCommand for match time counting down#8632PeterJohnson merged 2 commits intowpilibsuite:mainfrom
PeterJohnson merged 2 commits intowpilibsuite:mainfrom
Conversation
github-actions
bot
added
the
component: command-based
Contributor
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
Fixes wpilibsuite#8631 Documents that it will return immediately if FMS isn't attached or DS isn't in practice mode. Related to wpilibsuite#8606
sciencewhiz
force-pushed
the
FixWaitUntilTime
branch
from
1c44627 to
2054deb
Compare
sciencewhiz
added a commit
to sciencewhiz/mostrobotpy
that referenced
this pull request
Feb 23, 2026
Based on wpilibsuite/allwpilib#8632 Fixes issue reported in wpilibsuite/allwpilib#8631 Documents that it will return immediately if FMS isn't attached or DS isn't in practice mode. Related to change in DS match time behavior that was documented in wpilibsuite/allwpilib#8606
Contributor
Author
Opened robotpy/mostrobotpy#247 |
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/WaitUntilCommand.java
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/WaitUntilCommand.java
Outdated
Show resolved
Hide resolved
PeterJohnson
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8631
Documents that it will return immediately if FMS isn't attached or DS isn't in practice mode.
Related to change in DS match time behavior that was documented in #8606