[commandsv3] implement command contexts#8703
Closed
zachwaffle4 wants to merge 2 commits intowpilibsuite:2027from
Closed
[commandsv3] implement command contexts#8703zachwaffle4 wants to merge 2 commits intowpilibsuite:2027from
zachwaffle4 wants to merge 2 commits intowpilibsuite:2027from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivations of command contexts are described in the design document in this PR (which is slightly modified from the design document in Peter's PR).
This PR also only adds contexts to Commands v3; if this API is approved, a future PR will add them to Commands v2 (in both Java and C++).
Command OpModes for both v2 and v3 will be added in a future PR following #8652.