Show mechanism methods in the toolbox #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added INSTANCE_MECHANISM to FunctionKind enum to represent calling a mechanism instance method from the robot or from an OpMode. In renameMethodCaller, added code to update a block calling a component instance method if the component name is changed, and to update a block calling a mechanism instance method if the mechanism name or method name/signature is changed. Added functions addInstanceMechanismBlocks and createInstanceMechanismBlock. In mrc_component.ts: Added validator to the name field so we can call renameMethodCallers when the user changes the component name. Removed hideParams and mrcHideParams. Instead use module type to decide whether to hide parameters. Replaced getNewPort method with getArgName method, which uses both the component name and the arg name so the users knows what kind of ports (or other arguments) they are passing in. In mrc_mechanism.ts: Added validator to the name field so we can call renameMethodCallers when the user changes the mechanism name. In editor.ts: Added getMechanism method to get the Mechanism that correponds to the given MechanismInRobot. In common_storage.ts: Added some comments on className fields. In hardware_category.ts: Added code to getRobotMechanismsCategory to add a toolbox category with the methods for each mechanism that was added to the Robot. In methods_category.ts: Removed duplicate 'register_event' value.
|
This PR also improves the names of mechanism constructor parameters. |
alan412
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show mechanism methods in the toolbox.