Remove government option from mission types#558
Merged
Conversation
santostiago
approved these changes
Oct 16, 2025
Contributor
santostiago
left a comment
santostiago
left a comment
There was a problem hiding this comment.
All good, but shouldn't we run a migration to convert the ones that are government to something else? (or we don't have any?)
Collaborator
Author
|
Yes, there are no reports with government type mission in DB, so we are good. |
tsubik
force-pushed
the
feature/remove-government-from-mission-types
branch
from
48e184e to
a3d0c1e
Compare
Collaborator
Author
|
Ok, at least when I created that PR, there were none. Currently, I see a couple, so I will ask Sophie to update those accordingly, as I don't know what option to change to. |
tsubik
force-pushed
the
feature/remove-government-from-mission-types
branch
from
951ad80 to
5094e4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like it is not needed.
JIRA: https://gfw.atlassian.net/browse/OPEN-351?atlOrigin=eyJpIjoiZTljM2RhOTEzMGIyNGI5ZjllZGVlNjQzMWZkODFjMjIiLCJwIjoiaiJ9