Fix the startup error log with FileUploadExecutorManager#4495
Merged
madurangasiriwardena merged 1 commit intowso2:4.12.xfrom Feb 18, 2026
Merged
Fix the startup error log with FileUploadExecutorManager#4495madurangasiriwardena merged 1 commit intowso2:4.12.xfrom
madurangasiriwardena merged 1 commit intowso2:4.12.xfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![wso2-engineering[bot]](https://avatars.githubusercontent.com/in/1856828?s=60&v=4){kind=small}
Comment on lines
+235
to
+238
| ConfigurationContext contextForUpload = isLocalTransportMode ? serverConfigContext : clientConfigContext; | ||
| FileUploadExecutorManager fileUploadExecutorManager = | ||
| new FileUploadExecutorManager(context, contextForUpload, webContext); | ||
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| ConfigurationContext contextForUpload = isLocalTransportMode ? serverConfigContext : clientConfigContext; | |
| FileUploadExecutorManager fileUploadExecutorManager = | |
| new FileUploadExecutorManager(context, contextForUpload, webContext); | |
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); | |
| ConfigurationContext contextForUpload = isLocalTransportMode ? serverConfigContext : clientConfigContext; | |
| FileUploadExecutorManager fileUploadExecutorManager = | |
| new FileUploadExecutorManager(context, contextForUpload, webContext); | |
| log.info("FileUploadExecutorManager initialized for context: " + (isLocalTransportMode ? "server" : "client")); | |
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); |
Comment on lines
+263
to
+264
| // Use the already-created fileUploadExecutorManager | ||
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| // Use the already-created fileUploadExecutorManager | |
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); | |
| // Use the already-created fileUploadExecutorManager | |
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); | |
| if (log.isDebugEnabled()) { | |
| log.debug("FileUploadServlet created with existing FileUploadExecutorManager"); | |
| } |
core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/transports/FileUploadServlet.java
Show resolved
Hide resolved
core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/transports/FileUploadServlet.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 | ||
| #### Log Improvement Suggestion No: 3 | ||
| #### Log Improvement Suggestion No: 4 |
madurangasiriwardena
force-pushed
the
error-log
branch
from
c04ab9f to
6018ef6
Compare
|
PR builder started |
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
Comment on lines
+236
to
+238
| FileUploadExecutorManager fileUploadExecutorManager = | ||
| new FileUploadExecutorManager(context, contextForUpload, webContext); | ||
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 1
Suggested change
| FileUploadExecutorManager fileUploadExecutorManager = | |
| new FileUploadExecutorManager(context, contextForUpload, webContext); | |
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); | |
| FileUploadExecutorManager fileUploadExecutorManager = | |
| new FileUploadExecutorManager(context, contextForUpload, webContext); | |
| log.info("FileUploadExecutorManager created for context: " + webContext); | |
| context.registerService(FileUploadExecutorManager.class.getName(), fileUploadExecutorManager, null); |
Comment on lines
+263
to
+264
| // Use the already-created fileUploadExecutorManager | ||
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); |
There was a problem hiding this comment.
Log Improvement Suggestion No: 2
Suggested change
| // Use the already-created fileUploadExecutorManager | |
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); | |
| // Use the already-created fileUploadExecutorManager | |
| Servlet fileUploadServlet = new FileUploadServlet(context, contextForUpload, webContext, fileUploadExecutorManager); | |
| log.debug("FileUploadServlet created with FileUploadExecutorManager"); |
core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/transports/FileUploadServlet.java
Show resolved
Hide resolved
core/org.wso2.carbon.ui/src/main/java/org/wso2/carbon/ui/transports/FileUploadServlet.java
Show resolved
Hide resolved
There was a problem hiding this comment.
AI Agent Log Improvement Checklist
- The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
- Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.
✅ Before merging this pull request:
- Review all AI-generated comments for accuracy and relevance.
- Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
| Comment | Accepted (Y/N) | Reason |
|---|---|---|
| #### Log Improvement Suggestion No: 1 | ||
| #### Log Improvement Suggestion No: 2 | ||
| #### Log Improvement Suggestion No: 3 | ||
| #### Log Improvement Suggestion No: 4 |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Feb 18, 2026
jenkins-is-staging
left a comment
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/22126480233
pavinduLakshan
approved these changes
Feb 18, 2026
bhagyasakalanka
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.