[bug-fix] Permission revoked approver can still perform workflow approval tasks#979
Merged
sadilchamishka merged 3 commits intowso2:masterfrom Sep 3, 2025
Merged
Conversation
...src/main/java/org/wso2/carbon/identity/rest/api/server/workflow/v1/core/WorkflowService.java
Show resolved
Hide resolved
...src/main/java/org/wso2/carbon/identity/rest/api/server/workflow/v1/core/WorkflowService.java
Show resolved
Hide resolved
AI Agent Log Improvement Checklist
✅ Before merging this pull request:
|
sadilchamishka
approved these changes
Sep 3, 2025
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Sep 3, 2025
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/17419342432
sadilchamishka
added a commit
that referenced
this pull request
Sep 3, 2025
[Sync][master -> next][#979]: [bug-fix] Permission revoked approver can still perform workflow approval tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update pending approval task corresponding to the workflow, when the flow is updated.
Approach
Invoke approvalService method to update pending approval request upon successful workflow update.
Related Issues
Related PRs
User stories
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning