Skip to content

[bug-fix] Permission revoked approver can still perform workflow approval tasks #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadilchamishka merged 3 commits into from
Sep 3, 2025
Merged

[bug-fix] Permission revoked approver can still perform workflow approval tasks #979

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b39e401
Add updating approval tasks on workflow update.
NutharaNR Sep 1, 2025
a5b1826
Change method name.
NutharaNR Sep 2, 2025
9c27660
Bump version.
NutharaNR Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .../main/java/org/wso2/carbon/identity/rest/api/server/workflow/v1/core/WorkflowService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,16 @@ public WorkflowResponse updateWorkflow(WorkflowRequest workflow, String workflow
currentWorkflow = createWorkflow(workflow, workflowId);
List<WorkflowTemplateParameters> templateProperties = workflow.getTemplate().getSteps();
List<Parameter> parameterList = createParameterList(workflowId, templateProperties);
List<Parameter> oldPrameterList =
workflowManagementService.getWorkflowParameters(workflowId);
workflowManagementService.addWorkflow(currentWorkflow, parameterList,
CarbonContext.getThreadLocalCarbonContext().getTenantId());
// Update the corresponding approval tasks if there are any.
approvalEventService.updateApprovalTasksOnWorkflowUpdate(workflowId, parameterList, oldPrameterList);
return getWorkflow(workflowId);
} catch (WorkflowClientException e) {
throw handleClientError(Constants.ErrorMessage.ERROR_CODE_CLIENT_ERROR_UPDATING_WORKFLOW, workflowId, e);
} catch (WorkflowException e) {
} catch (WorkflowException | WorkflowEngineException e) {
throw handleServerError(Constants.ErrorMessage.ERROR_CODE_ERROR_UPDATING_WORKFLOW, workflowId, e);
}
}
Expand Down
Loading