Conversation
There are multiple improvement that I have applied to this post processor. This happened on plans created for mutation with more than 30 fetches. Such plans have densely populated dependencies (each next fetch in a sequence depends on all fetches before). In the end that post-processor was completely rewritten. Things were done roughly in this order: * I have pre-computed the calculation of all dependencies per fetch. * Topological comparisons were simplified because the size of dependencies gives the good ordering, that is only followed by the fetch IDs. * In the pre-compute instead of using maps I drafted very simple implementation of bitset since fetch IDs are densely populated.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe PR updates the GraphQL tools dependency in both router modules to v2.20.1 and corrects a comment describing ChangesRouter dependency and defer test maintenance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the GraphQL tools release used by the router modules and corrects 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
Comment |
Router image scan passed✅ No security vulnerabilities found in image: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3216 +/- ##
==========================================
- Coverage 66.99% 62.99% -4.00%
==========================================
Files 778 266 -512
Lines 63328 31575 -31753
Branches 7847 0 -7847
==========================================
- Hits 42425 19890 -22535
+ Misses 18193 10144 -8049
+ Partials 2710 1541 -1169 🚀 New features to boost your workflow:
|
…652-router-high-cpu-on-queries-with-50-selections
There are multiple improvements that I have applied to this post processor.
This happened on plans created for mutations with more than 30 fetches.
Such plans have densely populated dependencies
(each next fetch in a sequence depends on all fetches before).
In the end that post-processor was completely rewritten.
Things were done roughly in this order:
dependencies gives the good ordering, that is only followed by the fetch IDs.
of bitset since fetch IDs are densely populated.
Summary by CodeRabbit
Chores
Documentation