Wrap all string autocomplete values in quotes, not just those containing whitespace#230
Merged
adamruzicka merged 1 commit intowvanbergen:masterfrom Sep 16, 2025
Merged
Conversation
Collaborator
|
Could we get some new tests for this? Edit: or maybe changing all the currently failing ones would do |
jeremylenz
force-pushed
the
string-autocomplete
branch
from
5ff6485 to
068d759
Compare
Contributor
Author
|
updated tests |
Contributor
Author
|
Not sure what's going on with the test failures now. can you rerun them @adamruzicka ? |
Collaborator
|
From what I recall jruby-head tests are always a bit wonky, I wouldn't loose any sleep over them |
Contributor
Author
|
Can we get this in? |
adamruzicka
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies AutoCompleteBuilder's
complete_value_from_dbmethod.Previously, DB values that were strings would automatically be wrapped in quotes if the values contained spaces.
Now, DB values that are strings are wrapped in quotes, regardless of contents.
This is so that special operators ('|', '>', etc) don't break queries. For a more detailed explanation of the issue, see theforeman/foreman_rh_cloud#1083.