-
-
Notifications
You must be signed in to change notification settings - Fork 459
feat!: Replace web-ext with @wxt-dev/runner
#1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: major
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for creative-fairy-df92c4 failed.
|
| if (wxt.config.browser === 'firefox' && wxt.config.manifestVersion === 3) { | ||
| throw Error( | ||
| 'Dev mode does not support Firefox MV3. For alternatives, see https://github.com/wxt-dev/wxt/issues/230#issuecomment-1806881653', | ||
| ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Extract to own PR.
|
|
||
| const debugBidi = debug.scoped('bidi'); | ||
|
|
||
| export interface BidiConnection extends Disposable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Extract disposable changes to own PR.
| DEFAULT_CHROMIUM_PREFS, | ||
| ), | ||
| args: [ | ||
| '--unsafely-disable-devtools-self-xss-warnings', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Add this flag?
|
This could also fix #137 |
Nope, not something I can implement for the same reasons mentioned in the issue. |
|
@aklinker1 If you've decided to back to using |
|
I realized there was a better way to eventually add support for this while I continue developing it - hence #2078 and the accompanying PR. We don't need to hard-cut over like this PR originally did, this package isn't a full replacement for This PR needs changed to support wxt/packages/wxt/src/core/resolve-config.ts Lines 674 to 685 in 19c1d0a
The goal with this package is to be a super light-weight, zero dependency alternative to
It probably will never support all the features of |
|
@aklinker1 I don't want to open new thread for this, but i want to know. |
|
The 36 branches? I could clean them up if it's bothering you. |
Overview
web-exthas few problems:web-ext-run)Relies on--load-extension, which has been deprecated (there are plans to upgrade to using the CDP./scripts/benchmarks/browser-startup.sh)web-ext@wxt-dev/runnerTODO
Manual Testing
This should open your browser.
Related Issue
N/A