-
-
Notifications
You must be signed in to change notification settings - Fork 459
fix!: Make web-ext a peer dependency
#2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## major #2079 +/- ##
========================================
Coverage ? 76.00%
========================================
Files ? 112
Lines ? 3046
Branches ? 692
========================================
Hits ? 2315
Misses ? 647
Partials ? 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@PatrykKuniczak I'll add you as a reviewer once this is ready so you can see one of my PRs. Also if you have any feedback, please share! |
web-ext a peer dependencyweb-ext a peer dependency and expose wxt.config.runner object to modules
web-ext a peer dependency and expose wxt.config.runner object to modulesweb-ext a peer dependency
Co-authored-by: Patryk Kuniczak <p.kuniczak@gmail.com>
PatrykKuniczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for helping make WXT better! |
Overview
Instead of hard switching to
@wxt-dev/runneras in #1700, first makeweb-exta peer dependency. Then it will be easy to add support for@wxt-dev/runneras a peer similar toweb-extwithout a breaking change, and give devs an easy path to migrate if they want.resolveConfig, allowing modules to override the default and provide their own runner. Follows standards for construction of other objects on thewxtinstance, likeloggerManual Testing
Related Issue
This PR closes #2078