-
-
Notifications
You must be signed in to change notification settings - Fork 459
fix: normalize path for createAnalytics of analytics/index.ts #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: normalize path for createAnalytics of analytics/index.ts #2013
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cfc29de to
c790009
Compare
c790009 to
0796e05
Compare
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
==========================================
- Coverage 76.13% 76.06% -0.07%
==========================================
Files 113 113
Lines 3050 3050
Branches 686 686
==========================================
- Hits 2322 2320 -2
- Misses 645 647 +2
Partials 83 83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1df2fc2 to
323c89c
Compare
|
@aklinker1 I'm also simplified import path in output file: |
|
@aklinker1 OK, IT DOESN'T WORK xD |
|
Ok. Export Edit: Actually, we should break this PR apart, one for exporting |
e70eedd to
9bc0a4b
Compare
9bc0a4b to
194ff3a
Compare
|
@aklinker1 Are you able to enable |
This reverts commit 9f50f7a4b2eaa188e07ee15c69b08477c431c22e.
… file of `analytics`
|
@aklinker1 Finally DONE :) |
|
Thanks for helping make WXT better! |
No, that's not a setting on github. You can't merge a PR without resolving conflicts anyways, either a merge commit or a rebase both do the job. |
|
@aklinker1 But if you can(if you didn't done it already), let's enable auto removing branches after merge, it'll be useful at least on our branches(because with auto-merge) i usually doesn't check PR after merge, with auto branch remove, we can avoid a loot of old unnecessary branches :) |
|
It's already enabled. Same problem, I think it's related to your PRs being from a fork. |


Overview
I've use normalize path for
createAnalysisfunc in output.Manual Testing
Let's run
pnpm -F analytics prepareand see new output of.wxt/analytics/index.ts, should be valid independent of OS.Related Issue
This PR closes #2008