-
-
Notifications
You must be signed in to change notification settings - Fork 459
feat: Export normalizePath from wxt module
#2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export normalizePath from wxt module
#2080
Conversation
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@wxt-dev/analytics
@wxt-dev/auto-icons
@wxt-dev/browser
@wxt-dev/i18n
@wxt-dev/module-react
@wxt-dev/module-solid
@wxt-dev/module-svelte
@wxt-dev/module-vue
@wxt-dev/runner
@wxt-dev/storage
@wxt-dev/unocss
@wxt-dev/webextension-polyfill
wxt
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 75.80% 76.06% +0.26%
==========================================
Files 113 113
Lines 3050 3050
Branches 686 686
==========================================
+ Hits 2312 2320 +8
+ Misses 653 646 -7
+ Partials 85 84 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aklinker1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if i should export
unnormalizePathalso, but i don't know.
No until someone needs it. Keep the public API footprint minimal.
If i need to document it(to let people know, this is exposed), if yes, how to do it, because it's overhelmed to find sth in that docs.
It will be documented in the release notes when released. Just double check that it has a good JSDoc comment, since the API reference is auto-generated based on those.
wxt modulenormalizePath from wxt module
normalizePath from wxt modulenormalizePath from wxt module
|
Thanks for helping make WXT better! |
Overview
I've exported
normalizePathfromwxt,I was wondering if i should export
unnormalizePathalso, but i don't know.And @aklinker1 let's tell me, if i need to document it(to let people know, this is exposed), if yes, how to do it, because it's overhelmed to find sth in that docs.
Manual Testing
Try to import it somewhere, and check if it works.
Related Issue
#2013 (comment)