Add pool-level field to limit VNC console access to one session per VM/host #6647
Conversation
stephenchengCloud
changed the base branch from
master
to
feature/limit-vnc-console
stephenchengCloud
force-pushed
the
private/stephenche/CP-54217
branch
from
a6d9ab5 to
df2787b
Compare
stephenchengCloud
force-pushed
the
private/stephenche/CP-54217
branch
from
df2787b to
aa00d9e
Compare
stephenchengCloud
force-pushed
the
private/stephenche/CP-54217
branch
4 times, most recently
from
ca81f54 to
881a2f7
Compare
|
Squashed the commits. |
|
Remove duplicated sign-off in commit message. |
This change introduces a new pool-level parameter that restricts VNC console access to a single active session per VM/host. This prevents multiple users from simultaneously connecting to the same VM console, preventing one user 'watching' another user operating a session. When the `limit_console_sessions` is true. - Enforced a single active VNC console connection per VM/host - Disable connection to websocket Signed-off-by: Stephen Cheng <[email protected]>
stephenchengCloud
force-pushed
the
private/stephenche/CP-54217
branch
from
881a2f7 to
ee86ee9
Compare
Signed-off-by: Stephen Cheng <[email protected]>
|
Fixed comments and tested. |
ocaml/xapi/console.ml
Outdated
| active_connections := VMSet.remove vm_id !active_connections | ||
| ) | ||
|
|
||
| let try_add vm_id = |
There was a problem hiding this comment.
try_add and remove are too specific for the internal implementation.
How about try_acquire and release?
There was a problem hiding this comment.
Now we use map instead of set to record the connection count, it seems try_add is better.
Changed remove to drop.
There was a problem hiding this comment.
Why not use a Hashtbl which is stateful that does not require the update-and-assign? But I'm fine using Map because it is most similar to Set and code changes will be smaller
There was a problem hiding this comment.
Yeah, Hashtbl and Map are both fine. I considered Hashtbl. The reason I chose Map is that Map is immutable, which is more Ocaml style.
Signed-off-by: Stephen Cheng <[email protected]>
|
Hi @robhoes |
Signed-off-by: Stephen Cheng <[email protected]>
First commit:
Introduces a new pool-level parameter that restricts VNC console access
to a single active session per VM/host.
This prevents multiple users from simultaneously connecting to the same VM console,
preventing one user 'watching' another user operating a session.
Second commit:
When the
limit_console_sessionsis true.Tested:
true
Only one console can be connected:
false
Both consoles can be connected: